Bee keeper robot upgrade #3530
Open
Bee keeper robot upgrade #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also simplified generic forestry converter
|
I'll add any such JARs to a repository just fine. Does this work and/or fail gracefully with a non-GTNH Gendustry build? |
|
We didn't make any API changes in gendustry, just a few bug fixes, so any version should work. |
Vexatos
requested changes
Sep 4, 2022
| @@ -244,6 +244,11 @@ batteryUpgrade3 { | |||
| ["oc:capacitor", chipDiamond, "oc:capacitor"] | |||
| [nuggetIron, "oc:capacitor", nuggetIron]] | |||
| } | |||
| beekeeperUpgrade { | |||
| input: [[ingotGold, blockGlass, ingotGold] | |||
| ["oc:circuitChip3", {item="Forestry:beealyzer"}, "oc:circuitChip3"] | |||
There was a problem hiding this comment.
Doesn't this use tier 3 components in a tier 2 upgrade? Whichever is the intended tier, it should be adjusted.
| } | ||
| else result(false, "No inventory?") | ||
|
|
||
| @Callback(doc = """function(side:number):boolean -- Swap the queen from the selected slot with the apiary at the specified side.""") |
There was a problem hiding this comment.
Suggested change
| @Callback(doc = """function(side:number):boolean -- Swap the queen from the selected slot with the apiary at the specified side.""") | |
| @Callback(doc = """function(side:number):boolean -- Swap the queen from the selected slot with the apiary on the specified side.""") |
| }) | ||
| } | ||
|
|
||
| @Callback(doc = """function(side:number):boolean -- Swap the drone from the selected slot with the apiary at the specified side.""") |
There was a problem hiding this comment.
Suggested change
| @Callback(doc = """function(side:number):boolean -- Swap the drone from the selected slot with the apiary at the specified side.""") | |
| @Callback(doc = """function(side:number):boolean -- Swap the drone from the selected slot with the apiary on the specified side.""") |
| }) | ||
| } | ||
|
|
||
| @Callback(doc = """function(side:number):number -- Get current progress percent for the apiary at the specified side.""") |
There was a problem hiding this comment.
Suggested change
| @Callback(doc = """function(side:number):number -- Get current progress percent for the apiary at the specified side.""") | |
| @Callback(doc = """function(side:number):number -- Get current progress percent for the apiary on the specified side.""") |
| withApiary(facing, housing => result(housing.getBeekeepingLogic.getBeeProgressPercent)) | ||
| } | ||
|
|
||
| @Callback(doc = """function(side:number):boolean -- Checks if current bee in the apiary at the specified side can work now.""") |
There was a problem hiding this comment.
Suggested change
| @Callback(doc = """function(side:number):boolean -- Checks if current bee in the apiary at the specified side can work now.""") | |
| @Callback(doc = """function(side:number):boolean -- Checks if current bee in the apiary on the specified side can work now.""") |
| return result(false, "No honey!") | ||
|
|
||
| val individual = BeeManager.beeRoot.getMember(specimen) | ||
| if (!individual.isAnalyzed) { |
There was a problem hiding this comment.
I think in addition to consuming honey, this function should also consume a reasonable amount of energy, to make it similar to other "scanning" components in the mod such as the geolyzer.
| 0 | ||
| } | ||
|
|
||
| @Callback(doc = """function(side:number):boolean -- Tries to add industrial upgrade from the selected slot to industrial apiary at the given side.""") |
There was a problem hiding this comment.
It would be nice if these callbacks were only available if gendustry is installed. I believe this can be done using the FilteredEnvironment interface.
| 0 | ||
| } | ||
|
|
||
| @Callback(doc = """function(side:number):boolean -- Tries to add industrial upgrade from the selected slot to industrial apiary at the given side.""") |
There was a problem hiding this comment.
Suggested change
| @Callback(doc = """function(side:number):boolean -- Tries to add industrial upgrade from the selected slot to industrial apiary at the given side.""") | |
| @Callback(doc = """function(side:number):boolean -- Tries to add industrial upgrade from the selected slot to industrial apiary on the specified side.""") |
| case _ => result(false, "Not facing an industrial apiary") | ||
| } | ||
| } | ||
| @Callback(doc = """function(side:number, slot: number):table -- Get industrial upgrade in the given slot of the industrial apiary at the given side.""") |
There was a problem hiding this comment.
Suggested change
| @Callback(doc = """function(side:number, slot: number):table -- Get industrial upgrade in the given slot of the industrial apiary at the given side.""") | |
| @Callback(doc = """function(side:number, slot: number):table -- Get industrial upgrade in the given slot of the industrial apiary on the specified side.""") |
| case _ => result(Unit, "Not facing an industrial apiary") | ||
| } | ||
| } | ||
| @Callback(doc = """function(side:number, slot: number):boolean -- Remove industrial upgrade from the given slot of the industrial apiary at the given side.""") |
There was a problem hiding this comment.
Suggested change
| @Callback(doc = """function(side:number, slot: number):boolean -- Remove industrial upgrade from the given slot of the industrial apiary at the given side.""") | |
| @Callback(doc = """function(side:number, slot: number):boolean -- Remove industrial upgrade from the given slot of the industrial apiary on the specified side.""") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to add gendustry dev binary to the libs because I didn't find any maven hosting 1.7.10 gendustry. That probably needs fixing, any ideas?