feat: add basic mqtt support #2412
Open
+4,039
−3,137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0un7-z3r0
changed the title
Pull Request Test Coverage Report for Build 10231290157Details
💛 - Coveralls |
c0un7-z3r0
changed the title
s-martin
requested changes
Aug 24, 2024
| """ | ||
| This file provides definitions for MQTT to RPC command aliases | ||
|
|
||
| See [] |
There was a problem hiding this comment.
This line could be removed.
pabera
reviewed
Nov 3, 2024
There was a problem hiding this comment.
Sorry, it took me a while to get back to Phoniebox coding. This is a great addition. I have made only a few comments, the quality of code looks alright for now.
How do you use this code? What does your integration look like? Am I correct that this code does not work with Home Automations out of the box yet?
Comment on lines
+205
to
+209
| client_id = cfg.setndefault("mqtt", "client_id", value="phoniebox-future3") | ||
| username = cfg.setndefault("mqtt", "username", value="phoniebox-dev") | ||
| password = cfg.setndefault("mqtt", "password", value="phoniebox-dev") | ||
| host = cfg.setndefault("mqtt", "host", value="127.0.0.1") | ||
| port = cfg.setndefault("mqtt", "port", value=1883) |
There was a problem hiding this comment.
Could we have some of those useful settings in jukebox.yaml?
Also, one addition I would prefer is to be able to enable/disable this functionality (e.g. through the jukebox.yaml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial support and functionality for MQTT. Trying to be downward compatible as much as possible so potential mqtt implementations are not totally broken. Not all legacy features could be ported since the current future3 is not supporting them. Yet.
This PR referes to #1963