-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET 8.0 upgrade and additions from original project #82
Conversation
@yashints @rob-foulkrod @unaihuete93 @petender I would love to have your validation to this upgrade. For sure, I'm not asking to check file by file since it's huge but let me know if it's working fine for you thinking on AZ-400. The same project will be used in the new course DevOps Foundations. This pulls request includes changes to the eShopOnWeb project to upgrade it from .NET 7.0 to .NET 8.0. The most significant changes include updating the Docker configurations, modifying the GitHub workflows, and updating the project's dependencies. cc @lauraAlvEl |
Starting the review process now. There is a lot to go thru. :) I am getting a build warning due to an obsolete overload in 'src/ApplicationCore/Exceptions/EmptyBasketOnCheckoutException.cs'. Near as I can tell, the following method is old boilerplate and can be deleted.
Once delete, everything builds, and test run without warnings. |
@rob-foulkrod @yashints all fixed. I planning to approve this PR on Friday, so it fixes issues from AZ-400 and AZ-2008 new labs. Please, let me know if you see any issues and approve if possible! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runs and tests are all good
Hi there I was just doing the LABS for AZ-400 since I am going to teach it in a few weeks as MCT. When I have deployed the app for the first time and try to access it (according to the lab guide), i get a When i look in the log files i found this error:
Which did make me loot at the source for Program.cs at line 32, where i see this: This code was added in the this commit: c656d9b Since there is no AZURE_KEY_VAULT_ENDPOINT in the configuration it ends up being "" (Empty), and we get this error. So the 'Updating dotnet to 8.0 and sync project' commit seems to have broken a lot of LABS. :-( A few days ago I tried another AZ-400 lab, and had the same error. |
Hi @theDiverDK, Can you confirm if this has already been addressed in the following thread? You need to follow the lab instructions from GitHub if your lab provider hasn't updated theirs. |
Hi @lauraAlvEl I can confirm, adding: UseOnlyInMemoryDatabase = true To configuration did solve the issue. In 5 minutes, I am going through the whole lab, from: To check it again :) |
This pull request includes significant changes to the
eShopOnWeb
project, primarily aimed at upgrading the project from ASP.NET Core 7.0 to ASP.NET Core 8.0, and adding new functionality and configurations for Azure deployment, testing, and CI/CD.The most important changes include:
devcontainer.json
[1] [2] [3].editorconfig
,.gitattributes
, and Visual Studio Code settings [1] [2] [3]Changes by theme:
Upgrading to ASP.NET Core 8.0:
README.md
: Updated references to ASP.NET Core 7.0 to ASP.NET Core 8.0. [1] [2] [3]Directory.Packages.props
: Updated the project to use ASP.NET Core 8.0 and related packages..github/workflows/eshoponweb-cicd.yml
: Updated the GitHub Actions workflow to use .NET 8.0.x..vscode/launch.json
: Updated the program path to usenet8.0
.Docker and Azure Developer CLI configurations:
.devcontainer/Dockerfile
: Removed the old Dockerfile..devcontainer/devcontainer.json
: Removed the old devcontainer configuration and added a new one for using themcr.microsoft.com/devcontainers/dotnet:8.0
image and Azure Developer CLI. [1] [2]README.md
: Added instructions for running the sample using Azure Developer CLI.GitHub Actions workflows:
.github/workflows/dotnetcore.yml
: Added a new GitHub Actions workflow for building and testing the project..github/workflows/richnav.yml
: Added a new GitHub Actions workflow for code indexing..github/workflows/eshoponweb-cicd.yml
: Updated the existing GitHub Actions workflow to use .NET 8.0.x.Other changes:
.editorconfig
: Updated thevisual_basic_preferred_modifier_order
setting..gitattributes
: Added new settings for handling line endings..github/dependabot.yml
: Added a new Dependabot configuration for automatic NuGet package updates..vscode/extensions.json
: Added thems-azuretools.azure-dev
extension.README.md
: Updated the README with new instructions and information about the changes. [1] [2] [3] [4]