Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improve performance of JwtConfigExtension #717

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

KyleAure
Copy link
Collaborator

  • Short circuit when certain conditions are not meet for use of the JwtConfigExtension
  • Perform after execution cleanup only when before execution setup was done.

@KyleAure KyleAure added the is:housekeeping A maintenance task label Oct 22, 2024
@KyleAure KyleAure self-assigned this Oct 22, 2024
@KyleAure KyleAure force-pushed the perf-improvmenets branch 2 times, most recently from e74d5c6 to 8cb952f Compare October 22, 2024 21:51
@KyleAure KyleAure marked this pull request as ready for review October 22, 2024 21:54
@KyleAure KyleAure requested a review from appiepollo14 October 22, 2024 21:54
Copy link
Collaborator

@appiepollo14 appiepollo14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Approved.

@appiepollo14 appiepollo14 merged commit 3c1f250 into MicroShed:main Oct 23, 2024
13 checks passed
@KyleAure KyleAure deleted the perf-improvmenets branch October 23, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:housekeeping A maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants