Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves todo in Contribution.md for container engines #318

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Solves todo in Contribution.md for container engines #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
620b4dd
Update dependency jekyll to "~> 3.9.0"
renovate[bot] Nov 8, 2023
ec87922
Update dependency io.rest-assured:rest-assured to v4.5.1
renovate[bot] Nov 8, 2023
92165db
Merge branch 'MicroShed:main' into master
appiepollo14 Nov 11, 2023
202db6a
Updates CONTRIBUTING.md to explain required container engine and link…
appiepollo14 Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ If your Pull Request results in the failure of this build it will not be reviewe
##### Requirements

- JDK 11 or higher
- Docker (daemon or desktop)
<!-- TODO support podman/colima for builds -->
- Any container engine, e.g. Docker, Podman, Colima. As this project is build on top of testcontainers, see their [documentation](https://golang.testcontainers.org/system_requirements/using_podman/) on how to use another container engine than Docker by default.

##### Building project

Expand Down
2 changes: 1 addition & 1 deletion docs/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ source "https://rubygems.org"
#
# This will help ensure the proper Jekyll version is running.
# Happy Jekylling!
gem "jekyll", "~> 3.8.5"
gem "jekyll", "~> 3.9.0"

gem 'jekyll-feed'

Expand Down
2 changes: 1 addition & 1 deletion sample-apps/everything-app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies {
testCompile group: 'org.slf4j', name: 'slf4j-log4j12', version: '1.7.36'
testCompile 'org.testcontainers:mockserver:1.19.1'
testCompile 'org.mock-server:mockserver-client-java:5.5.4'
testCompile 'io.rest-assured:rest-assured:4.2.0'
testCompile 'io.rest-assured:rest-assured:4.5.1'
testImplementation 'org.junit.jupiter:junit-jupiter:5.10.1'
}

Expand Down