Skip to content

Conversation

reachtokish
Copy link

What: Added Google Slides support

Why: Fixes issue #96

How: Added GoogleSlides.js and necessary tests

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

Hi @MichaelDeBoey, I have raised this PR so that this plugin can support to embed Google Slides. I have written the required codes for that and also added tests. Though npm run test:update failing and throwing error Jest: "global" coverage threshold for branches (100%) not met: 99.16% - like this. I think I could not cover tests for all the codes.

Kindly check whole the things and please let me know what else I have to do to make it all fix. I'm quite new in gatsby and also I've never used this plugin but wanted to give a try.

Thanks!!

@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bb5b8a8) to head (cea1763).
Report is 74 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #114   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        17    +1     
  Lines          215       227   +12     
  Branches        27        27           
=========================================
+ Hits           215       227   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MichaelDeBoey MichaelDeBoey added the ⚙︎ Google Slides Issue or pull request regarding Google Slides label Apr 13, 2020
@MichaelDeBoey MichaelDeBoey changed the title Support for google slides feat(Google Slides): Add support for Google Slides Apr 13, 2020
@MichaelDeBoey MichaelDeBoey linked an issue Apr 16, 2020 that may be closed by this pull request
@reachtokish reachtokish marked this pull request as ready for review April 22, 2020 16:35
@MichaelDeBoey MichaelDeBoey self-assigned this Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙︎ Google Slides Issue or pull request regarding Google Slides
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Google Slides
2 participants