feat: add --subpackage option to update multiple derivations
#311
+186
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
av-gal
force-pushed
the
multiple-subpackages
branch
from
89b2bd8 to
cdd631d
Compare
|
Can we get a test for this? |
av-gal
force-pushed
the
multiple-subpackages
branch
from
78e9b10 to
6575daf
Compare
|
Test added, it's just a simplified version of what I'm packaging. Thanks for your time, please let me know if there's anything else. |
Mic92
force-pushed
the
multiple-subpackages
branch
from
6575daf to
ab661ac
Compare
|
@av-gal I added some documentation. Please check. |
Mic92
force-pushed
the
multiple-subpackages
branch
from
ab661ac to
03005af
Compare
av-gal
force-pushed
the
multiple-subpackages
branch
from
03005af to
61113ae
Compare
|
I fixed a typo in the name of the option, and expanded your comment about repeating the option for multiple subpackages. Otherwise, LGTM. |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 33baee5 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option for users to specify subpackages that
nix-updateshould also look at.nix-updatewill evaluate these sub-derivations after updating the package's version and source, but before trying to evaluate the package's main derivation. This allows for subpackages that are depended upon by the main package build.Not included is any sort of accommodation for sub-subpackages. I hope those do not occur often in real builds.
Closes #310.