-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand testing for expanded-view notifications #2956
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2956 +/- ##
==========================================
+ Coverage 94.72% 94.74% +0.02%
==========================================
Files 497 497
Lines 10825 10868 +43
Branches 1654 1669 +15
==========================================
+ Hits 10254 10297 +43
Misses 571 571 ☔ View full report in Codecov by Sentry. |
hmalik88
changed the title
Update notification example snap
Expand testing for expanded-view notifications
Dec 17, 2024
Mrtenz
reviewed
Dec 18, 2024
Mrtenz
requested changes
Jan 8, 2025
hmalik88
changed the title
Expand testing for expanded-view notifications
BREAKING: Expand testing for expanded-view notifications
Jan 8, 2025
hmalik88
changed the title
BREAKING: Expand testing for expanded-view notifications
Expand testing for expanded-view notifications
Jan 10, 2025
Mrtenz
previously approved these changes
Jan 10, 2025
Mrtenz
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@metamask/notification-example-snap
to have a method to trigger an expanded view notification.test-snaps
to trigger the new methods added above.snaps-jest
to allow for unit testing of expanded view notifications.