Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand testing for expanded-view notifications #2956

Merged
merged 25 commits into from
Jan 10, 2025

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Dec 14, 2024

  1. Updated the @metamask/notification-example-snap to have a method to trigger an expanded view notification.
  2. Updated test-snaps to trigger the new methods added above.
  3. Updated snaps-jest to allow for unit testing of expanded view notifications.

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.74%. Comparing base (f21e859) to head (ca6b3dc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2956      +/-   ##
==========================================
+ Coverage   94.72%   94.74%   +0.02%     
==========================================
  Files         497      497              
  Lines       10825    10868      +43     
  Branches     1654     1669      +15     
==========================================
+ Hits        10254    10297      +43     
  Misses        571      571              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmalik88 hmalik88 changed the title Update notification example snap Expand testing for expanded-view notifications Dec 17, 2024
@hmalik88 hmalik88 marked this pull request as ready for review December 17, 2024 22:21
@hmalik88 hmalik88 requested a review from a team as a code owner December 17, 2024 22:21
@hmalik88 hmalik88 marked this pull request as draft December 18, 2024 22:15
@hmalik88 hmalik88 marked this pull request as ready for review December 23, 2024 20:40
packages/examples/packages/notifications/tsconfig.json Outdated Show resolved Hide resolved
packages/snaps-jest/src/global.ts Show resolved Hide resolved
packages/snaps-jest/src/global.ts Show resolved Hide resolved
packages/snaps-jest/src/matchers.test.tsx Show resolved Hide resolved
packages/snaps-jest/src/matchers.ts Outdated Show resolved Hide resolved
packages/snaps-simulation/src/interface.test.tsx Outdated Show resolved Hide resolved
packages/snaps-simulation/src/request.ts Outdated Show resolved Hide resolved
@hmalik88 hmalik88 changed the title Expand testing for expanded-view notifications BREAKING: Expand testing for expanded-view notifications Jan 8, 2025
@hmalik88 hmalik88 changed the title BREAKING: Expand testing for expanded-view notifications Expand testing for expanded-view notifications Jan 10, 2025
Mrtenz
Mrtenz previously approved these changes Jan 10, 2025
@hmalik88 hmalik88 merged commit e68e282 into main Jan 10, 2025
164 checks passed
@hmalik88 hmalik88 deleted the hm/update-notification-example branch January 10, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants