fix(kernel): sending messages to terminated vats #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirtimid
commented
Sep 5, 2025
| @@ -145,7 +145,7 @@ export class KernelRouter { | |||
| if (this.#kernelStore.isRevoked(targetObject)) { | |||
| return routeAsSplat(kser('revoked object')); | |||
| } | |||
| const vatId = this.#kernelStore.getOwner(targetObject); | |||
| const vatId = this.#kernelStore.getOwner(targetObject, false); | |||
There was a problem hiding this comment.
this just prevents getOwner to throw
There was a problem hiding this comment.
Should we just get rid of the second param of getOwner()? Before this change it was only ever true, now it is only ever false in production code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #613
Fix when sending messages to objects owned by terminated vats, the kernel should reject the message with a "no vat" error. Added a test to validate.