Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove require-additional-reviewer workflow #148

Merged
merged 1 commit into from
Nov 18, 2022
Merged

ci: remove require-additional-reviewer workflow #148

merged 1 commit into from
Nov 18, 2022

Conversation

legobeat
Copy link
Contributor

context: #135 (comment)

@legobeat legobeat mentioned this pull request Nov 18, 2022
Closed
@Gudahtt
Copy link
Member

Gudahtt commented Nov 18, 2022 •
edited
Loading

We can also remove these lines

metamask-module-template/.github/workflows/create-release-pr.yml

Lines 42 to 48 in 56b7fd5

artifacts-path: gh-action__release-authors
# Upload the release author artifact for use in subsequent workflows
- uses: actions/upload-artifact@v3
with:
name: release-authors
path: gh-action__release-authors
if-no-files-found: error

That "PR authors" artifact, being generated by the artifacts-path parameter to action-create-release-pr, and being updated by the upload-artifact step, is solely used to support this require-additional-reviewer workflow.

@legobeat legobeat force-pushed the remove-require-additional-reviewer branch from 443a7b8 to 7b41072 Compare November 18, 2022 02:03
@legobeat
Copy link
Contributor Author

We can also remove these lines

metamask-module-template/.github/workflows/create-release-pr.yml

Lines 42 to 48 in 56b7fd5

artifacts-path: gh-action__release-authors
# Upload the release author artifact for use in subsequent workflows
- uses: actions/upload-artifact@v3
with:
name: release-authors
path: gh-action__release-authors
if-no-files-found: error

That "PR authors" artifact, being generated by the artifacts-path parameter to action-create-release-pr, and being updated by the upload-artifact step, is solely used to support this require-additional-reviewer workflow.

Great, thanks, updated!

@legobeat legobeat marked this pull request as ready for review November 18, 2022 02:05
@legobeat legobeat requested a review from a team as a code owner November 18, 2022 02:05
Gudahtt
Gudahtt approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit b24417c into MetaMask:main Nov 18, 2022
@legobeat legobeat deleted the remove-require-additional-reviewer branch November 18, 2022 12:57
@mcmire mcmire mentioned this pull request Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @Gudahtt