Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: Token search #13328

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[WIP] feat: Token search #13328

wants to merge 3 commits into from

Conversation

ziad-saab
Copy link
Contributor

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.


useEffect(() => {
if (!tokenResult) {
Engine.context.TokensController.addSearchedToken(address, chainId);
Copy link
Contributor

@gambinish gambinish Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user searches for a token on a network not yet added to their account, we won't have some data needed to handle certain fiat conversion throughout the app (for instance, on AsssetOverview)

From a technical perspective, this may require us to add the required chain to the NetworkController state whenever you TokensController.addSearchedToken(), so that the networkConfigurations.[chainId].nativeCurrency for the fiat conversion is also available for the UI to consume.

We will likely also want to handle the network switch on behalf of the user, so that the correct network appears below the ticker on the TabView:

Screenshot 2025-02-05 at 1 41 20 PM

Slack conversation for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants