feat: QR hardware signing in new designs

[jpuri]

Description

QR hardware signing in new designs

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4058

Manual testing steps

1. Connect to QR wallet
2. Import QR account
3. Sign QR sign request

Screenshots/Recordings

TODO

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 86a442b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fdf408ba-aaee-4b48-9265-9c90872ea36f

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sleepytanya]

@jpuri

Bitrise QA builds https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/106d1a13-fdd2-4671-9391-1ca33b3930af?tab=workflows

iPhone 15, Samsung S24+

All QR signatures work as expected on both platforms, except for the Sign Typed Data - Invalid QR Code message on the Keystone and Keyring Controller error in the test-dapp.

Android:

android.mov

iOS:

ios.mov

[jpuri]

Hey @sleepytanya : typed sign works for me using Airgap vault:

can you plz check if you notice this in old designs also, this may be a thing I need to check with hardware team

[jpuri]

From discussion with hardware wallet team:

this is a known issue. Keystone do not support sign typed data v1 signings.

[digiwand]

can we update the description and add screenshots please? it can be hard to find screenshots with many comments. could also be helpful to note that logic has been carried from other files and reorganized here to be more scalable for the new confirmation pages.

when we extend this logic to transactions, we will need to remember that RESET_TRANSACTION event was called on the old logic, when finalizing the QR request, and will need to be reintegrated

[jpuri]

can we update the description and add screenshots please? it can be hard to find screenshots with many comments. could also be helpful to note that logic has been carried from other files and reorganized here to be more scalable for the new confirmation pages.

when we extend this logic to transactions, we will need to remember that RESET_TRANSACTION event was called on the old logic, when finalizing the QR request, and will need to be reintegrated

I am having bit hard time to capture screenshot from real device, but you can check Tanya's findings for it.

About RESET_TRANSACTION I think this will be called for all transactions QR or normal once they are cancelled.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2a5a1de
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/06971ac6-cbcb-4524-9bc5-32b851a35cfb

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.7% Coverage on New Code
6.2% Duplication on New Code

See analysis details on SonarQube Cloud