Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update transaction-controller version #12228

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Nov 7, 2024

Description

This PR aims to update transaction-controller to latest version.
The issue with previous version is fixed here: MetaMask/core#4897

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested review from a team as code owners November 7, 2024 10:07
@OGPoyraz OGPoyraz added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 7, 2024
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Nov 7, 2024
@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-confirmations Push issues to confirmations team labels Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b38bb92
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b3784972-bc6a-4dc1-8629-12032915f417

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Nov 7, 2024

@OGPoyraz OGPoyraz added team-confirmations Push issues to confirmations team and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Nov 7, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit fde99ea Nov 7, 2024
54 of 59 checks passed
@sethkfman sethkfman deleted the fix/update-tc-version branch November 7, 2024 20:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@sleepytanya
Copy link
Contributor

Bitrise builds:

https://app.bitrise.io/app/be69d4368ee7e86d/installable-artifacts/bd28ac7f2a1a0f74

Gas estimation works as expected on Base, BNB and OpBNB.

iOS:

1.mov
2.mov

The app unexpectedly quits on Android devices due to a bug that is not related to the current PR. Gas estimations seem to be working on Android as well:

3.mp4

@sleepytanya sleepytanya added the QA Passed A successful QA run through has been done label Nov 8, 2024
@gauthierpetetin gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants