Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: xchain tx details use short names #29413

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Dec 20, 2024

Description

Open in GitHub Codespaces

This PR uses short names for networks to improve spacing.

Related issues

Fixes:

Manual testing steps

  1. Do a bridge tx
  2. Click on bridge tx in Activity
  3. Observe shorter names

Screenshots/Recordings

Before

Screenshot 2024-12-20 at 5 19 46 PM

Screenshot 2024-12-20 at 5 19 54 PM

After

Screenshot 2024-12-20 at 5 20 13 PM
Screenshot 2024-12-20 at 5 20 20 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower changed the title Mb1833 xchain tx details short names chore: xchain tx details use short names Dec 20, 2024
@infiniteflower infiniteflower marked this pull request as ready for review December 20, 2024 22:23
@infiniteflower infiniteflower requested a review from a team as a code owner December 20, 2024 22:23
@metamaskbot
Copy link
Collaborator

Builds ready [84d0af0]
Page Load Metrics (1684 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15631968168311153
domContentLoaded15111945165511555
load15602014168412058
domInteractive26175483517
backgroundConnect96425168
firstReactRender1776472311
getState561202010
initialActions01000
loadScripts11111491123810149
setupStore6491194
uiStartup17412243190013464
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 560 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants