Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove second inner scroll bar from tx details #29412

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Dec 20, 2024

Description

Open in GitHub Codespaces

This PR removes the 2nd inner scrollbar from Bridge tx details.

Related issues

Fixes:

Manual testing steps

  1. Do a bridge tx
  2. Get navigated to Activity list
  3. Click on a bridge tx
  4. Observe only 1 scroll bar

Screenshots/Recordings

Before

Screenshot 2024-12-20 at 5 03 15 PM

After

Screenshot 2024-12-20 at 5 19 06 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower marked this pull request as ready for review December 20, 2024 22:23
@infiniteflower infiniteflower requested a review from a team as a code owner December 20, 2024 22:23
@metamaskbot
Copy link
Collaborator

Builds ready [8972ee2]
Page Load Metrics (1605 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1463179916089244
domContentLoaded1449178115838742
load1457179816058742
domInteractive21136453014
backgroundConnect97928178
firstReactRender16179474019
getState56613168
initialActions00000
loadScripts1055137011798340
setupStore67915199
uiStartup163023401893211101
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -32 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants