Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (cherry-pick): remove reliance on transaction decode in confirmations #29341 #29399

Open
wants to merge 2 commits into
base: Version-v12.10.0
Choose a base branch
from

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Dec 20, 2024

Description

Cherry-pick of #29341 for release 12.10.0.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Dec 20, 2024
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners December 20, 2024 17:44
@metamaskbot
Copy link
Collaborator

Builds ready [7af9f60]
Page Load Metrics (1677 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14872194168315172
domContentLoaded14222172164415374
load14312197167715474
domInteractive2488442411
backgroundConnect1099342814
firstReactRender1670312210
getState587192110
initialActions01000
loadScripts10691696122912560
setupStore66411126
uiStartup16662473191719996
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 3 Bytes (0.00%)
  • ui: -1008 Bytes (-0.01%)
  • common: -160 Bytes (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants