Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [POM] Migrate connections e2e tests to TS and Page Object Model #29384

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

chloeYue
Copy link
Contributor

@chloeYue chloeYue commented Dec 20, 2024

Description

  • Migrate connections e2e tests to TS and Page Object Model
test/e2e/tests/connections/edit-account-flow.spec.ts
test/e2e/tests/connections/edit-networks-flow.spec.ts
  • Remove the spec test/e2e/tests/connections/connect-with-metamask.spec.js as it's already completely tested in another spec. We don't want to repeat testing.

  • create more class methods for permission page class

Open in GitHub Codespaces

Related issues

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue added team-extension-platform e2e-test End to end test for the MetaMask extension labels Dec 20, 2024
@chloeYue chloeYue self-assigned this Dec 20, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue changed the title test: Chloe connections tests test: [POM] Migrate connections e2e tests to TS and Page Object Model Dec 20, 2024
@chloeYue chloeYue marked this pull request as draft December 20, 2024 11:12
@metamaskbot
Copy link
Collaborator

Builds ready [955d3fe]
Page Load Metrics (1674 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14901872167810852
domContentLoaded14391844164411555
load14751854167411354
domInteractive238040168
backgroundConnect774352010
firstReactRender1583432713
getState55316147
initialActions00000
loadScripts1056137912378641
setupStore66411136
uiStartup16902309195315173
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue marked this pull request as ready for review December 20, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-test End to end test for the MetaMask extension team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants