Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add the new policy.json review process documentation and config #29383

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naugtur
Copy link
Contributor

@naugtur naugtur commented Dec 20, 2024

Description

Introducing the document outlining policy review process.

The current change to CODEOWNERS doesn't remove the all devs group - this makes it a soft-launch of the process where a specific approving review is not yet mandatory.

We'll be releasing a training video early January

Open in GitHub Codespaces

Related issues

Fixes: lack of attention to policy updates

Manual testing steps

  1. Follow the process and experience joy

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [fe9af48]
Page Load Metrics (1558 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13632015156113264
domContentLoaded13481928152912058
load13671962155812259
domInteractive2085382010
backgroundConnect106329199
firstReactRender1573322211
getState44912126
initialActions00000
loadScripts1001144911489043
setupStore620831
uiStartup15182194175713062
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants