Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove obsolete keys #29372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Remove obsolete keys #29372

wants to merge 1 commit into from

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 20, 2024

Description

Remove references to obsolete keys.

  • PUBNUB_*: These were used for the old mobile state sync feature, which was removed a long time ago.
  • ETHERSCAN_KEY: This was used for incoming transactions, but we've since switched to our own API.
  • OPENSEA_KEY: We've switched to Reservoir

The ETHERSCAN_KEY environment variable is still refrenced in the gridplus-sdk package, so it has been left in the build.yml file as null to indicate that it's intentionally unset.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@@ -761,8 +761,6 @@ export default class MetamaskController extends EventEmitter {
}),
});

this.nftController.setApiKey(process.env.OPENSEA_KEY);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove references to obsolete keys.
* PUBNUB_*: These were used for the old mobile state sync feature,
which was removed a long time ago.
* Etherscan: This was used for incoming transactions, but we've since
switched to our own API.
* Opensea: We've switched to Reservoir
@Gudahtt Gudahtt force-pushed the remove-obsolete-keys branch from d1a9507 to 2069269 Compare December 20, 2024 05:04
# Unset environment variables cause a build error. These are set to `null` to tell our build
# system that they are intentionally unset.
###
- ETHERSCAN_KEY: null # Used by `gridplus-sdk/dist/util.js`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not being exfiltrated or anything. Gridplus optionally uses it to fetch contract calldata from Etherscan.

@metamaskbot
Copy link
Collaborator

Builds ready [2069269]
Page Load Metrics (1938 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint41425401781518249
domContentLoaded147324101903248119
load152924531938252121
domInteractive2699532010
backgroundConnect992332210
firstReactRender1798422512
getState589312612
initialActions00000
loadScripts10691913145620799
setupStore65916178
uiStartup175330642228341164
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -35 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt marked this pull request as ready for review December 20, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants