-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove obsolete keys #29372
base: main
Are you sure you want to change the base?
chore: Remove obsolete keys #29372
Conversation
@@ -761,8 +761,6 @@ export default class MetamaskController extends EventEmitter { | |||
}), | |||
}); | |||
|
|||
this.nftController.setApiKey(process.env.OPENSEA_KEY); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was still being set, but it did nothing: https://github.com/MetaMask/core/blob/f8e5f2e3cadecc44c1c5b40b3ed3c36d154346cb/packages/assets-controllers/src/NftController.ts#L1382
(see that the key isn't used anywhere).
Remove references to obsolete keys. * PUBNUB_*: These were used for the old mobile state sync feature, which was removed a long time ago. * Etherscan: This was used for incoming transactions, but we've since switched to our own API. * Opensea: We've switched to Reservoir
d1a9507
to
2069269
Compare
# Unset environment variables cause a build error. These are set to `null` to tell our build | ||
# system that they are intentionally unset. | ||
### | ||
- ETHERSCAN_KEY: null # Used by `gridplus-sdk/dist/util.js` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not being exfiltrated or anything. Gridplus optionally uses it to fetch contract calldata from Etherscan.
Builds ready [2069269]
Page Load Metrics (1938 ± 121 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
Remove references to obsolete keys.
The
ETHERSCAN_KEY
environment variable is still refrenced in thegridplus-sdk
package, so it has been left in thebuild.yml
file asnull
to indicate that it's intentionally unset.Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist