feat: persist bridge state through ToS click #29366

bfullam · 2024-12-19T21:05:11Z

Description

Currently, clicking on Terms takes you to an external page and resets your bridge progress. We want to follow the same UX as swaps, where if the user clicks on the ToS link, the extension will close, but when the user reopens the extension, they remain on the bridge page.

Acceptance Criteria:

When clicking on the ToS link, the extension closes. But when the user re-opens the extension, they see the bridge page with tokens inputted (but not amounts)

Related issues

Fixes:

Manual testing steps

Go to bridge
Put in tokens/amounts to get quote
Click "terms" link
Reopen extension and see inputs persisted

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-19T21:05:23Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

This reverts commit 0fcea9f.

metamaskbot · 2024-12-19T23:43:39Z

Builds ready [cc56cad]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1587 ± 108 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1384	2122	1589	224	107
		domContentLoaded	1348	2094	1564	213	102
		load	1384	2125	1587	224	108
		domInteractive	22	70	37	15	7
		backgroundConnect	9	68	25	18	9
		firstReactRender	15	90	43	27	13
		getState	4	62	14	17	8
		initialActions	0	1	0	0	0
		loadScripts	986	1672	1181	181	87
		setupStore	6	11	7	1	1
		uiStartup	1566	2417	1798	263	126

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 511 Bytes (0.01%)
common: 0 Bytes (0.00%)

micaelae

If you close the pop up or click the link in the middle of a quote fetch (with enough balance) does it abort the fetching loop in the background worker?

micaelae

Can you add this behavior to the e2e test scenarios doc so it's not missed when qa is testing? Would be good to also add something about the hardware confirmations too

infiniteflower

It doesn't work for me. The bridge state gets reset.

ui/pages/bridge/prepare/prepare-bridge-page.tsx

bfullam · 2024-12-20T17:00:44Z

If you close the pop up or click the link in the middle of a quote fetch (with enough balance) does it abort the fetching loop in the background worker?

@micaelae the ToS link only exists as part of the quote card, which only displays after the quotes have completed fetching

metamaskbot · 2024-12-20T17:36:17Z

Builds ready [6510e14]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1746 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1564	2009	1755	109	52
		domContentLoaded	1556	1987	1712	101	49
		load	1564	2016	1746	105	50
		domInteractive	24	84	39	19	9
		backgroundConnect	9	81	39	21	10
		firstReactRender	16	105	50	31	15
		getState	4	54	16	15	7
		initialActions	0	1	0	0	0
		loadScripts	1163	1469	1299	76	36
		setupStore	6	91	16	22	11
		uiStartup	1704	2605	2095	237	114

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 512 Bytes (0.01%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-12-20T18:48:58Z

Builds ready [ee39ed1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1783 ± 86 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	255	2086	1689	366	176
		domContentLoaded	1537	2052	1760	165	79
		load	1546	2092	1783	180	86
		domInteractive	15	204	44	39	18
		backgroundConnect	8	85	23	24	11
		firstReactRender	16	85	46	26	12
		getState	4	52	13	13	6
		initialActions	0	1	0	0	0
		loadScripts	1101	1561	1291	140	67
		setupStore	7	68	21	22	10
		uiStartup	1805	2393	2042	193	93

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 514 Bytes (0.01%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-12-20T22:15:17Z

Builds ready [dd7b471]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1682 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	222	2099	1620	345	166
		domContentLoaded	1512	2031	1658	123	59
		load	1522	2041	1682	123	59
		domInteractive	24	88	38	19	9
		backgroundConnect	8	83	33	23	11
		firstReactRender	15	102	45	33	16
		getState	5	84	14	20	10
		initialActions	0	1	0	0	0
		loadScripts	1094	1430	1228	96	46
		setupStore	7	88	24	27	13
		uiStartup	1755	2622	2059	231	111

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 556 Bytes (0.01%)
common: 0 Bytes (0.00%)

bfullam added 5 commits December 18, 2024 16:19

Redirect to bridge if quotes are present in state

8b692db

feat: redirect to beidge if bridge quote is present on page load

8e2f744

feat: hydrate bridge inputs if active quote is present on page load

f2f22da

test: update test

7ea59cf

Merge branch 'main' into mms-1818-persist-bridge-state-through-ToS-click

702edc9

bfullam requested review from a team as code owners December 19, 2024 21:05

bfullam added the team-swaps label Dec 19, 2024

bfullam added 6 commits December 19, 2024 13:21

chore: lint

b39f2fc

test: update storybook tests

0fcea9f

test: update story tests

868f985

Revert "test: update storybook tests"

9535bbf

This reverts commit 0fcea9f.

chore: check for nulls before hydrating bridge inputs

7e0d17c

chore: remove unnecessary null check

cc56cad

bfullam enabled auto-merge December 19, 2024 23:45

micaelae requested changes Dec 20, 2024

View reviewed changes

micaelae reviewed Dec 20, 2024

View reviewed changes

infiniteflower reviewed Dec 20, 2024

View reviewed changes

ui/pages/bridge/prepare/prepare-bridge-page.tsx Show resolved Hide resolved

infiniteflower reviewed Dec 20, 2024

View reviewed changes

ui/pages/bridge/prepare/prepare-bridge-page.tsx Outdated Show resolved Hide resolved

refactor: use decimalToPrefixedHex instead of decimalToHex

6510e14

bfullam added 3 commits December 20, 2024 10:04

refactor: check asset type with isNativeAddress instead of type property

7a10d0c

refactor: always reset bridge state on load

057f135

chore: lint

ee39ed1

micaelae previously approved these changes Dec 20, 2024

View reviewed changes

refactor: only reset bridge state if active quote is not present

dd7b471

bfullam dismissed micaelae’s stale review via dd7b471 December 20, 2024 21:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: persist bridge state through ToS click #29366

feat: persist bridge state through ToS click #29366

bfullam commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024

metamaskbot commented Dec 19, 2024

micaelae left a comment •

edited

Loading

micaelae left a comment

infiniteflower left a comment •

edited

Loading

bfullam commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

feat: persist bridge state through ToS click #29366

Are you sure you want to change the base?

feat: persist bridge state through ToS click #29366

Conversation

bfullam commented Dec 19, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 19, 2024

metamaskbot commented Dec 19, 2024

micaelae left a comment • edited Loading

Choose a reason for hiding this comment

micaelae left a comment

Choose a reason for hiding this comment

infiniteflower left a comment • edited Loading

Choose a reason for hiding this comment

bfullam commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

bfullam commented Dec 19, 2024 •

edited

Loading

micaelae left a comment •

edited

Loading

infiniteflower left a comment •

edited

Loading