-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import all detected tokens automatically #29357
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
tested with and without the feature flag on , works as expected , PR approved but you need to check the failing e2e test |
Builds ready [eae8fbb]
Page Load Metrics (1686 ± 95 ms)
Bundle size diffs
|
|
||
await Promise.all(importPromises); | ||
} else { | ||
await dispatch(addImportedTokens(detectedTokens, networkClientId)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just changing the else to else if (detectedTokens?.length > 0) {
Description
Now that we have most users autodetect tokens, we can make the UX even more streamlined. This PR automatically add in tokens we detect on behalf of users.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-439
Manual testing steps
Make sure the token detection is working properly:
Screenshots/Recordings
Before
Screen.Recording.2024-12-20.at.11.28.14.mov
After
Screen.Recording.2024-12-20.at.11.25.27.mov
Pre-merge author checklist
Pre-merge reviewer checklist