Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating header to use heading sm #29308

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −18
Draft

chore: updating header to use heading sm #29308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/components/app/assets/nfts/nft-details/__snapshots__/nft-full-image.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ exports[`NFT full image should match snapshot 1`] = `
<div
class="mm-box"
>
<p
class="mm-box mm-text mm-text--body-md-bold mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default"
<h2
class="mm-box mm-text mm-text--heading-sm mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default"
/>
Comment on lines -20 to 22
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add logic to remove the Text component if children is not present

</div>
<div
Expand Down
6 changes: 3 additions & 3 deletions ui/components/multichain/pages/connections/__snapshots__/connections.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ exports[`Connections Content should render correctly 1`] = `
<div
class="mm-box"
>
<p
class="mm-box mm-text mm-text--body-md-bold mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default"
<h2
class="mm-box mm-text mm-text--heading-sm mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default"
>
<div
class="mm-box connections-header__title mm-box--display-flex mm-box--gap-2 mm-box--justify-content-center mm-box--align-items-center"
Expand All @@ -45,7 +45,7 @@ exports[`Connections Content should render correctly 1`] = `
metamask.github.io
</span>
</div>
</p>
</h2>
</div>
</div>
<div
Expand Down
3 changes: 2 additions & 1 deletion ui/components/multichain/pages/page/components/header/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,9 @@ export const Header = ({
{...props}
>
<Text
as="h2"
display={Display.Block}
variant={TextVariant.bodyMdBold}
variant={TextVariant.headingSm}
textAlign={TextAlign.Center}
paddingInlineStart={8}
paddingInlineEnd={8}
Expand Down
6 changes: 3 additions & 3 deletions ui/components/multichain/pages/permissions-page/__snapshots__/permissions-page.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@ exports[`All Connections render renders correctly 1`] = `
<div
class="mm-box"
>
<p
class="mm-box mm-text mm-text--body-md-bold mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default"
<h2
class="mm-box mm-text mm-text--heading-sm mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default"
>
<span
class="mm-box mm-text mm-text--heading-md mm-text--text-align-center mm-box--color-text-default"
>
Permissions
</span>
</p>
</h2>
</div>
</div>
<div
Expand Down
6 changes: 3 additions & 3 deletions ...tichain/pages/review-permissions-page/__snapshots__/review-permissions-page.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ exports[`ReviewPermissions should render correctly 1`] = `
<div
class="mm-box"
>
<p
class="mm-box mm-text mm-text--body-md-bold mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default"
<h2
class="mm-box mm-text mm-text--heading-sm mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default"
>
<div
class="mm-box connections-header__title mm-box--display-flex mm-box--gap-2 mm-box--justify-content-center mm-box--align-items-center"
Expand All @@ -43,7 +43,7 @@ exports[`ReviewPermissions should render correctly 1`] = `
class="mm-box mm-text mm-text--heading-md mm-text--ellipsis mm-text--text-align-center mm-box--color-text-default"
/>
</div>
</p>
</h2>
</div>
</div>
<div
Expand Down
12 changes: 6 additions & 6 deletions ui/pages/permissions-connect/connect-page/__snapshots__/connect-page.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ exports[`ConnectPage should render correctly 1`] = `
<div
class="mm-box"
>
<p
class="mm-box mm-text mm-text--body-md-bold mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default"
<h2
class="mm-box mm-text mm-text--heading-sm mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default"
>
<h2
class="mm-box mm-text mm-text--heading-lg mm-box--color-text-default"
Expand All @@ -29,7 +29,7 @@ exports[`ConnectPage should render correctly 1`] = `
This site wants to
:
</p>
</p>
</h2>
</div>
</div>
<div
Expand Down Expand Up @@ -265,8 +265,8 @@ exports[`ConnectPage should render with defaults from the requested permissions
<div
class="mm-box"
>
<p
class="mm-box mm-text mm-text--body-md-bold mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default"
<h2
class="mm-box mm-text mm-text--heading-sm mm-text--ellipsis mm-text--text-align-center mm-box--padding-inline-start-8 mm-box--padding-inline-end-8 mm-box--display-block mm-box--color-text-default"
>
<h2
class="mm-box mm-text mm-text--heading-lg mm-box--color-text-default"
Expand All @@ -279,7 +279,7 @@ exports[`ConnectPage should render with defaults from the requested permissions
This site wants to
:
</p>
</p>
</h2>
</div>
</div>
<div
Expand Down
Loading