Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate token balances controller #28276

Closed
wants to merge 46 commits into from

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Nov 4, 2024

Description

Starting to replace the https://github.com/MetaMask/eth-token-tracker library with reading state from the TokenBalancesController.

There's a hook useTokenBalances that can be used to poll and return token balances across chains and accounts. As well as a backcompat hook meant to ease the transition away from eth-token-tracker.

Depends on MetaMask/core#4782

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron changed the base branch from develop to brian/use-accounts-api-for-token-detection2 November 4, 2024 17:48
@bergeron bergeron changed the base branch from brian/use-accounts-api-for-token-detection2 to develop November 4, 2024 17:48
@MetaMask MetaMask deleted a comment from socket-security bot Nov 4, 2024
@bergeron
Copy link
Contributor Author

bergeron commented Nov 4, 2024

fixed yarn.lock

@bergeron bergeron changed the title wip: integrate token balances controller feat: integrate token balances controller Nov 4, 2024
@bergeron
Copy link
Contributor Author

replaced by #28472

@bergeron bergeron closed this Nov 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants