-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate token balances controller #28276
Closed
Closed
+227
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ask-extension into brian/asset-controller-39
… brian/currency-rate-multichain-polling2
…MetaMask/metamask-extension into brian/multiexchangerate
… brian/multiexchangerate
…k-extension into brian/multiexchangerate
… brian/token-balances-controller
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…/metamask-extension into brian/token-balances-controller
bergeron
changed the base branch from
develop
to
brian/use-accounts-api-for-token-detection2
November 4, 2024 17:48
bergeron
changed the base branch from
brian/use-accounts-api-for-token-detection2
to
develop
November 4, 2024 17:48
fixed yarn.lock |
bergeron
changed the title
wip: integrate token balances controller
feat: integrate token balances controller
Nov 4, 2024
7 tasks
replaced by #28472 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting to replace the https://github.com/MetaMask/eth-token-tracker library with reading state from the TokenBalancesController.
There's a hook useTokenBalances that can be used to poll and return token balances across chains and accounts. As well as a backcompat hook meant to ease the transition away from eth-token-tracker.
Depends on MetaMask/core#4782
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist