feat: multi chain polling for token prices #28158

bergeron · 2024-10-29T15:32:41Z

Description

Multi chain polling for the token rates controller. This will fetch erc20 token prices across all evm chains.

Related issues

Manual testing steps

no visual changes, you should just see the network tab hitting price api across multiple chains, correct prices when switching chains, when adding new tokens, and marketData updated in state across chains

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ask-extension into brian/asset-controller-39

github-actions · 2024-10-29T15:32:53Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ui/pages/index.js

… brian/currency-rate-multichain-polling2

metamaskbot · 2024-11-01T08:58:40Z

Builds ready [3bf7b78]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2370 ± 114 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	336	2876	2172	653	314
		domContentLoaded	2015	2864	2333	240	115
		load	2076	2877	2370	237	114
		domInteractive	29	144	76	32	15
		backgroundConnect	7	86	39	26	13
		firstReactRender	82	381	152	82	39
		getState	7	100	29	24	11
		initialActions	0	1	0	0	0
		loadScripts	1501	2181	1762	191	92
		setupStore	15	89	35	26	12
		uiStartup	2274	3244	2703	334	161

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 82 Bytes (0.00%)
ui: 2.66 KiB (0.03%)
common: 556 Bytes (0.01%)

…ient id (#4887) ## Explanation Updates the polling input for `TokenRatesController` to a chain id instead of a network client id. ## References * Related to MetaMask/metamask-extension#28158 ## Changelog  ### `@metamask/assets-controllers` - **BREAKING**: The `TokenRatesController` now accepts `{chainId: Hex}` as its polling input to `startPolling()` instead of `{networkClientId: NetworkClientId}` ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

…k-extension into brian/multiexchangerate

metamaskbot · 2024-11-04T02:28:03Z

Builds ready [316da04]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1931 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1590	2374	1936	210	101
		domContentLoaded	1581	2359	1909	208	100
		load	1590	2378	1931	211	101
		domInteractive	17	104	61	22	11
		backgroundConnect	8	87	23	19	9
		firstReactRender	49	193	97	30	14
		getState	5	67	25	24	11
		initialActions	0	1	0	0	0
		loadScripts	1138	1871	1421	180	87
		setupStore	11	70	33	22	11
		uiStartup	1788	2638	2172	222	107

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 125 Bytes (0.00%)
ui: 1.98 KiB (0.03%)
common: 1.05 KiB (0.01%)

metamaskbot · 2024-11-04T03:47:18Z

Builds ready [9a777f6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1908 ± 211 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	312	2137	1579	517	248
		domContentLoaded	1630	3555	1882	437	210
		load	1639	3578	1908	439	211
		domInteractive	16	86	46	19	9
		backgroundConnect	8	96	31	25	12
		firstReactRender	47	261	104	52	25
		getState	4	58	15	17	8
		initialActions	0	0	0	0	0
		loadScripts	1170	2892	1398	390	187
		setupStore	10	91	33	26	12
		uiStartup	1796	4076	2155	522	251

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 125 Bytes (0.00%)
ui: 1.98 KiB (0.03%)
common: 1.05 KiB (0.01%)

bergeron and others added 12 commits October 22, 2024 14:30

bump asset controllers to 39

85fe12d

update ConfirmTransaction

0f3cd64

fix useGasFeeEstimates unit test

bdf921b

fix usePolling tests

9bc4ecf

bump controller utils

9b1529b

remove patch

c8bcc0b

Merge branch 'develop' into brian/asset-controller-39

d1a3782

Update LavaMoat policies

05fd6ef

lint

9dfdfa8

Merge branch 'brian/asset-controller-39' of github.com:MetaMask/metam…

04ea3d6

…ask-extension into brian/asset-controller-39

Merge branch 'develop' into brian/asset-controller-39

cf66072

initial multi chain polling for currency and token rates

785de28

github-actions bot added the team-assets label Oct 29, 2024

bergeron changed the base branch from develop to brian/asset-controller-39 October 29, 2024 15:39

bergeron commented Oct 29, 2024

View reviewed changes

ui/pages/index.js Outdated Show resolved Hide resolved

Base automatically changed from brian/asset-controller-39 to develop October 29, 2024 16:11

bergeron and others added 13 commits October 29, 2024 11:23

fix testnets

f461767

only refetch prices on chains whose tokens changed

f1da818

poll multiple native currencies

878f407

fix test

e8a9d6a

yarn dedupe

245f8d3

Update LavaMoat policies

1afebee

Merge branch 'develop' into brian/currency-rate-multichain-polling2

e99e2ef

fix e2e test mocks

ca590ec

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

d2191ac

… brian/currency-rate-multichain-polling2

fix e2e test

70c0db4

.

6b7df4d

lint

4e816c2

fix e2e test

aaef377

bergeron mentioned this pull request Nov 1, 2024

update TokenRatesController to poll on chain id instead of network client id MetaMask/core#4887

Merged

4 tasks

bergeron added 2 commits November 1, 2024 10:15

make polling input a chain id

bb1f278

Merge branch 'develop' into brian/multiexchangerate

14dc84b

bergeron added 9 commits November 1, 2024 15:38

bump to asset controller v42

ef3ef10

.

ab6e7cc

Merge branch 'brian/multiexchangerate' of github.com:MetaMask/metamas…

44861d9

…k-extension into brian/multiexchangerate

AssetPollingProvider

5833fb8

comment

095b870

comments

be976f6

lint

237fd4d

Merge branch 'develop' into brian/multiexchangerate

795f27d

input type

f9b5763

bergeron marked this pull request as ready for review November 4, 2024 01:42

bergeron added 3 commits November 3, 2024 17:43

stopAllPolling

d445e84

comment

bbf0e4e

tsx

316da04

.

9a777f6

sahar-fehri approved these changes Nov 4, 2024

View reviewed changes

bergeron enabled auto-merge November 4, 2024 15:45

gambinish approved these changes Nov 4, 2024

View reviewed changes

bergeron added this pull request to the merge queue Nov 4, 2024

Merged via the queue into develop with commit eab6233 Nov 4, 2024
76 checks passed

bergeron deleted the brian/multiexchangerate branch November 4, 2024 16:18

github-actions bot locked and limited conversation to collaborators Nov 4, 2024

metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: multi chain polling for token prices #28158

feat: multi chain polling for token prices #28158

bergeron commented Oct 29, 2024 •

edited

Loading

github-actions bot commented Oct 29, 2024

metamaskbot commented Nov 1, 2024

metamaskbot commented Nov 4, 2024

metamaskbot commented Nov 4, 2024

feat: multi chain polling for token prices #28158

feat: multi chain polling for token prices #28158

Conversation

bergeron commented Oct 29, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 29, 2024

metamaskbot commented Nov 1, 2024

metamaskbot commented Nov 4, 2024

metamaskbot commented Nov 4, 2024

bergeron commented Oct 29, 2024 •

edited

Loading