Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CAIP Multichain (New) #27782

Draft
wants to merge 366 commits into
base: caip25-permission-migration
Choose a base branch
from
Draft

feat: CAIP Multichain (New) #27782

wants to merge 366 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jul 9, 2024

  1. Update LavaMoat policies

    @metamaskbot
    metamaskbot committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    74360e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Jl/caip multichain/provider request spec (#25709) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

* Fix wallet namespace handling in provider_request
* Add provider_request spec

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25709?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    62d8904 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Jl/caip multichain/handle accounts provider authorize (#25708) 

    NOTE: We may want to get [this child
branch](#25713)
merged into this branch first before making the remaining changes to
accounts behavior


<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

* Checks if accounts specified in the `accounts` property exist in the
Keyring API
* Requests the `eth_accounts` permission using those accounts (makes the
assumption they are evm)
* Removes random property sessions from my initial implementation

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25708?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Shane <[email protected]>
Co-authored-by: Alex <[email protected]>
    @jiexi @shanejonas @adonesky1
    3 people authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    161352d View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. fix: add caip25 caveat mutator for removeAccounts (#25784) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25784?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @shanejonas
    shanejonas authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    e72a44a View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    c787255 View commit details
    Browse the repository at this point in the history

  2. Sj/caip multichain getinternal (#25836) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Currently we don’t believe account validation is necessary since we will
only ever take accounts that are sourced from the keyring.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25836?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @shanejonas
    shanejonas authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e0c7961 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. remove methods from multichain API (#25841) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25841?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @adonesky1
    adonesky1 authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    dbf562a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7921a31 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8990171 View commit details
    Browse the repository at this point in the history

  2. Jl/caip multichain/lifecycle methods (#25842) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

* Add `wallet_getSession`
* Add `wallet_revokeSession`
* Emit `wallet_sessionChanged` on authorization change
* Note this does not include specs. Seems we are not currently testing
accountChanged and chainChanged events and should probably get those
covered first

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25842?quickstart=1)

## **Related issues**

See: MetaMask/MetaMask-planning#2821

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c9c03ad View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    5352f11 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    9b765e6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    1c97f86 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6c24aa8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a1b1707 View commit details
    Browse the repository at this point in the history

  3. Update LavaMoat policies

    @metamaskbot
    metamaskbot committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    249c79d View commit details
    Browse the repository at this point in the history

  4. Allow empty ScopesObject (#25956) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Loosen ScopesObject validation to allow empty objects

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25956?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    c8dad3d View commit details
    Browse the repository at this point in the history

  5. Jl/caip multichain/fix provider request scope object check (#25957) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Adds back scope check in provider_request

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25957?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a2d6660 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    66c4785 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b40039b View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    b78d54b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    1ce1cd0 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    90ce686 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    7dce004 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d094982 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    01ae68d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    65cbc45 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5c0d59b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    fea21ac View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4e0e372 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1fe52e8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    4a6b810 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0f721bf View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Jl/caip multichain/permission adapter (#26054) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

* Fix `wallet` scope getting filtered out of persisted CAIP-25
permission
* Update EIP-1193 eth_accounts handler to return accounts from the
unique set of all CAIP-25 authorized eip155 accounts when BARAD_DUR flag
is set
* Update EIP-1193 eth_requestAccounts handler to also grant an CAIP-25
permission for the chain with the permitted accounts when BARAD_DUR flag
is set
* Remove eth_accounts and eth_requestAccounts handlers from Multichain
API (fixed)
* Replace PermissionController method handlers with Multichain adapted
ones
  * Update wallet_getPermissions
    * Never return caip25:endowment permission
* Replaces/Sets eth_accounts permission using caip25 permission if
exists
  * Update wallet_requestPermissions
    * Never return caip25:endowment permission
* Do not allow caip25:endowment permission to be passed from params to
PermissionController.requestPermissions
* Grant/Update an CAIP-25 permission for the chain with the permitted
accounts when BARAD_DUR flag is set
  * Update wallet_revokePermissions
* Do not allow caip25:endowment permission to be passed from params to
PermissionController.revokePermissions
* Removes all accounts from eip155 scopes if caip25 permission exists
when BARAD_DUR flag is set


[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26054?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Alex Donesky <[email protected]>
    @jiexi @adonesky1
    jiexi and adonesky1 authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    bdf7d8c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    8241e50 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    51eb1a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    cf3a472 View commit details
    Browse the repository at this point in the history

  2. Jl/caip multichain/scoped properties eip3085 (#25873) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

* `provider_authorize` accepts `scopedProperties` field for `eip3085`
  * Ignores invalid/irrelevant `scopedProperties`
* `provider_authorize` throws error if any `requiredScopes` that are not
already supported and will not potentially be supported by `eip3085` in
`scopedProperties`
* `provider_authorize` ignores any `optionalScopes` that are not already
supported and will not potentially be supported by `eip3085` in
`scopedProperties`
* `provider_authorize` upserts relevant valid `eip3085`
`scopedProperties` and rolls back if the request fails
* `provider_authorize` buckets required and optional scopes by
supported, supportable, and unsupported
* Refactors `provider_authorize` for easier testing
* Refactors some existing logic into helpers, i.e.
`assignAccountsToScopes`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25873?quickstart=1)

## **Related issues**

See: MetaMask/MetaMask-planning#2828

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Alex Donesky <[email protected]>
    @jiexi @adonesky1
    jiexi and adonesky1 authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    d50ded1 View commit details
    Browse the repository at this point in the history

  3. Jl/caip multichain/fix camel case naming (#26199) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26199?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    8fd734e View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0918a06 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    225a220 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    8027888 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0a1c1b0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    604f716 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Jl/caip multichain/fix e2e (#26237) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Get CI passing again

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26237?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b38272b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    49d8d66 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1d2d8a0 View commit details
    Browse the repository at this point in the history

  2. Update LavaMoat policies

    @metamaskbot
    metamaskbot committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    61f6fc3 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    b8d9baa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    dbd1a60 View commit details
    Browse the repository at this point in the history

  3. Jl/caip multichain/caip 25 permission origin (#26296) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

* Add `isMultichainOrigin` flag to the CAIP-25 permission
* Unsure if this should have been added as a separate caveat or not
though
* Consider CAIP-25 permission inapplicable in the multichain flow if
`isMultichainOrigin` is false for the existing authorization
* Allow all previously implicit permissions in the EIP-1193 flow when
there is a no CAIP-25 permission, or the CAIP-25 permission has
`isMultichainOrigin` as false
* Enforce the CAIP-25 permission in the EIP-1193 flow when the CAIP-25
permission has `isMultichainOrigin` true
* Set `isMultichainOrigin` true when CAIP-25 permission is granted as
part of the multichain flow via `provider_authorize`
* Set `isMultichainOrigin` false when a CAIP-25 permission is granted
(not updated) as part of `eth_requestAccounts` or
`wallet_requestPermissions` in the EIP-1193 flow

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26296?quickstart=1)

## **Related issues**

See: MetaMask/MetaMask-planning#2922
See: MetaMask/MetaMask-planning#2862

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <[email protected]>
    @jiexi @metamaskbot
    jiexi and metamaskbot authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    9b4192e View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    db99e33 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Update LavaMoat policies

    @metamaskbot
    metamaskbot committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9774d0e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    47f95db View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    18e331d View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    bedb6d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Added multichain api notifications (#25869) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Added multichain api notifications
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25869?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Jiexi Luan <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: MetaMask Bot <[email protected]>
    @shanejonas @jiexi
    @adonesky1 @metamaskbot
    4 people authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2d05d3c View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d293acf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8b3a37c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3017965 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9df3320 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d6d8f2d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    07f83d5 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    684f45e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4887166 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    ba828e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2ba1522 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1fda368 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    773e11c View commit details
    Browse the repository at this point in the history

  3. Fix caip25 permission spec type

    @jiexi
    jiexi committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d46d3bb View commit details
    Browse the repository at this point in the history

  4. WIP

    @jiexi
    jiexi committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    bbbf8e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge branch 'develop' into caip-multichain 

    # Conflicts:
#	lavamoat/browserify/beta/policy.json
#	lavamoat/browserify/flask/policy.json
#	lavamoat/browserify/main/policy.json
#	lavamoat/browserify/mmi/policy.json
    @jiexi
    jiexi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    f323cb4 View commit details
    Browse the repository at this point in the history

  2. lavamoat

    @jiexi
    jiexi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b575fb4 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/jl/caip-multichain/type-cleanups… 

    …' into caip-multichain
    @jiexi
    jiexi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    db362d9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    4bd882c View commit details
    Browse the repository at this point in the history

  5. Revert "Fix caip25 permission spec type" 

    This reverts commit d46d3bb.
    @jiexi
    jiexi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    a71c617 View commit details
    Browse the repository at this point in the history

  6. Revert "WIP" 

    This reverts commit bbbf8e5.
    @jiexi
    jiexi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    dcb3094 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d893751 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Merge branch 'develop' into caip-multichain 

    # Conflicts:
#	lavamoat/browserify/beta/policy.json
#	lavamoat/browserify/flask/policy.json
#	lavamoat/browserify/main/policy.json
#	lavamoat/browserify/mmi/policy.json
    @jiexi
    jiexi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    f3692d9 View commit details
    Browse the repository at this point in the history

  2. Update LavaMoat policies

    @metamaskbot
    metamaskbot committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    958f864 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    a260e5e View commit details
    Browse the repository at this point in the history

  4. Jl/caip multichain/misc cleanup (#26724) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Misc cleanup. Removing `KnownCaipNamespace` is still not possible
because `@metamask/util` does not have a `Wallet` enum value

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26724?quickstart=1)

## **Related issues**

See: MetaMask/MetaMask-planning#3050

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9fb5fed View commit details
    Browse the repository at this point in the history

  5. Jl/caip multichain/provider authorize metrics (#26699) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

* Add metrics to `provider_authorize`
* Add jsdoc to `removeScope()`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26699?quickstart=1)

## **Related issues**

See: MetaMask/MetaMask-planning#3049

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    a9e92c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9eef5fe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    8baf1a5 View commit details
    Browse the repository at this point in the history

  3. Jl/caip multichain/test cleanups (#26698) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Test cleanup chores

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26698?quickstart=1)

## **Related issues**

See: MetaMask/MetaMask-planning#3046

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    26b4aa2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    2d6ccff View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    704e52e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    3b16fbd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    7ddc677 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f838a96 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f9e30ff View commit details
    Browse the repository at this point in the history

  2. Jl/caip multichain/replace known caip namespace with metamask utils (#… 

    …26765)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Replaces our internal KnownCaipNamespaces enum with one that was added
in `@metamask/utils` 9.2.0, but is patched into 8.5.1 on this branch

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26765?quickstart=1)

## **Related issues**

See: MetaMask/MetaMask-planning#3050

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    aa92005 View commit details
    Browse the repository at this point in the history

  3. Jl/caip multichain/migrate permission eth accounts to caip25 (#26483) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26483?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Build with `BARAD_DUR=1 CHAIN_PERMISSIONS=1`
2.
3.

```
await window.ethereum.request({
  "method": "wallet_getPermissions"
});

// Should implicitly request the permittedChains endowment
await window.ethereum.request({
  "method": "wallet_requestPermissions",
  "params": [
    {
      "eth_accounts": {},
    }
  ]
});

await window.ethereum.request({
  "method": "wallet_revokePermissions",
  "params": [
    {
      "eth_accounts": {},
      "permittedChains": {}
    }
  ]
});

await window.ethereum.request({
  "method": "wallet_switchEthereumChain",
  "params": [
    {
      "chainId": "0x1"
    }
  ]
});

await window.ethereum.request({
  "method": "eth_requestAccounts"
});


await window.ethereum.request({
  "method": "eth_accounts"
});
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Alex Donesky <[email protected]>
    @jiexi @adonesky1
    jiexi and adonesky1 authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    58106a5 View commit details
    Browse the repository at this point in the history

  4. Sj/caip multichain api specs test (#26643) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
This PR adds a new command `yarn test:api-specs-multichain` that uses
externally_connectable as a transport and runs a custom
`MultichainAuthorizationConfirmation` rule. It also writes an html
report to `html-report-multichain`.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26643?quickstart=1)

## **Related issues**

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2834

## **Manual testing steps**

1. `BARAD_DUR=1 yarn build:test`
2. `yarn test:api-specs-multichain`

## **Screenshots/Recordings**

![image](https://github.com/user-attachments/assets/8eb1267a-60aa-4ba2-9cfb-15f7c20c7e62)

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @shanejonas
    shanejonas authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e7a9d2d View commit details
    Browse the repository at this point in the history

  5. Jl/caip multichain/namespaced methods (#26732) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Split methods into `eip155`, `wallet`, and `wallet:eip155` namespaces

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26732?quickstart=1)

## **Related issues**

See: MetaMask/MetaMask-planning#3036

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7331f50 View commit details
    Browse the repository at this point in the history

  6. Remove prepopulated methods and notifications (#26877) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

As discussed with Alex, we don't actually need to prepopulate the
CAIP-25 scopes granted from the EIP-1193 API with methods/notifications

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26877?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    41ea73b View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    bea1e18 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    bca508e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    191b717 View commit details
    Browse the repository at this point in the history

  4. Jl/mmp 3048/caip multichain error handling cleanup (#26825) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Error cleanup

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26825?quickstart=1)

## **Related issues**

See: MetaMask/MetaMask-planning#3048

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    93ed08e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5c048ff View commit details
    Browse the repository at this point in the history

  6. Fix provider_authorize missing hooks (#26926) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Whelp, my bad.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26926?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    995b386 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Jl/mmp 3037/caip multichain rename methods (#26928) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

* Rename `provider_authorize` -> `wallet_createSession`
* Rename `provider_requests` -> `wallet_invokeMethod`
* Format `eth_subscription` responses with `wallet_notify`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26928?quickstart=1)

## **Related issues**

See: MetaMask/MetaMask-planning#3037

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    577f337 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e54be4b View commit details
    Browse the repository at this point in the history

  3. yarn dedupe

    @jiexi
    jiexi committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    370dfd1 View commit details
    Browse the repository at this point in the history

  4. Jl/caip multichain/remove 5301 error (#26915) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

As discussed in the CASA meeting, we're using the 5301 error wrong. We
wouldn't want to fire it in our implementation either way so just
removing it now

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26915?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    70a2cdc View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    781aeb8 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. remove wallet_watchAsset from wallet:eip155 (#26954) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

* remove wallet_watchAsset from wallet:eip155
  * (which makes it a `eip155:x` scoped method)

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26954?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    dfacc49 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c5370c7 View commit details
    Browse the repository at this point in the history

  3. Jl/caip multichain/type cleanups (#26690) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

An effort to cleanup some lazy permission types and differentiate the
potentially unflattened/malformed ScopeObjects from a CAIP-25 request
and the internal flattened ScopeObjects that get persisted into the
PermissionController state.

I don't love the current Internal/External prefixing. Perhaps making the
external type `unknown` and keeping the unprefixed as the internal type
would be better. Thoughts?

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26690?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Alex Donesky <[email protected]>
    @jiexi @adonesky1
    jiexi and adonesky1 authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    2dfdbc3 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. fix: added initial provider authorize error rule (#26828) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26828?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. `CHAIN_PERMISSIONS=1 BARAD_DUR=1 yarn build:test`
2. `yarn test:api-specs-multichain`

## **Screenshots/Recordings**
<img width="1609" alt="image"
src="https://github.com/user-attachments/assets/7db111ad-e194-4799-83a3-783d5e943e65">

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <[email protected]>
    @shanejonas @metamaskbot
    shanejonas and metamaskbot authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    615da54 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge branch 'develop' into caip-multichain 

    # Conflicts:
#	lavamoat/browserify/beta/policy.json
#	lavamoat/browserify/flask/policy.json
#	lavamoat/browserify/main/policy.json
#	lavamoat/browserify/mmi/policy.json
    @jiexi
    jiexi committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    76cd526 View commit details
    Browse the repository at this point in the history

  2. Jl/caip multichain/fix wallet namespace validation and invoke (#27223) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

* Fix `wallet:eip155` not being considered a valid scopeString
* Fix EIP-1193 permission adapter not checking `wallet` and
`wallet:eip155` scopes for methods

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27223?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d24fc2a View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Merge branch 'develop' into caip-multichain 

    # Conflicts:
#	.gitignore
#	app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.js
#	app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.test.js
#	app/scripts/lib/rpc-method-middleware/handlers/eth-accounts.js
#	app/scripts/lib/rpc-method-middleware/handlers/ethereum-chain-utils.js
#	app/scripts/lib/rpc-method-middleware/handlers/switch-ethereum-chain.test.js
#	app/scripts/metamask-controller.js
#	app/scripts/migrations/127.test.ts
#	app/scripts/migrations/127.ts
#	package.json
#	test/e2e/fixture-builder.js
#	yarn.lock
    @jiexi
    jiexi committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    dec03c3 View commit details
    Browse the repository at this point in the history

  2. fix missing updateNetwork

    @jiexi
    jiexi committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    eb5805d View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    450ec01 View commit details
    Browse the repository at this point in the history

  2. Replace ScopeObject.scopes with ScopeObject.references (#27403) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Replaces `scopes` with `references` on `ScopeObject`

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27403?quickstart=1)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#3301

## **Manual testing steps**

```
const EXTENSION_ID = 'nonfpcflonapegmnfeafnddgdniflbnk';
const extensionPort = chrome.runtime.connect(EXTENSION_ID)
extensionPort.onMessage.addListener((msg) => console.log('extensionPort on message', msg))
extensionPort.postMessage({
    type: 'caip-x',
    data: {
        "jsonrpc": "2.0",
        method: 'wallet_createSession',
        params: {
            requiredScopes: {
                'eip155': {
                    references: ['1', '59144'],
                    methods: [
                        'eth_sendTransaction',
                        'eth_getBalance',
                        'eth_subscribe'
                    ],
                    notifications: ['eth_subscription'],
                }
            },
            optionalScopes: {
            },
            sessionProperties: {
                'caip154-mandatory': 'true',
            },
        },
    }
})
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    fec21c4 View commit details
    Browse the repository at this point in the history

  3. Caip multichain caip 27 api spec tests (#27229) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
This adds api spec tests that utilize `externally_connectable` as well
as `caip-27` requests to wrap the "legacy" api-spec tests.

It refactors a lot into `transform.ts` to help reduce duplication since
we want to test it the same way as our current api-spec tests.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27229?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. `CHAIN_PERMISSIONS=1 BARAD_DUR=1 yarn build:test`
2. `yarn test:api-spec-multichain`
3. see multiple html reporters pop up with all passing.

## **Screenshots/Recordings**
<img width="1309" alt="image"
src="https://github.com/user-attachments/assets/035a1725-b215-4d7c-982c-9867814113b4">

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <[email protected]>
    @shanejonas @metamaskbot
    shanejonas and metamaskbot authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dd02132 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Sj/caip multichain api spec tests ci (#27317) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27317?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <[email protected]>
    @shanejonas @metamaskbot
    shanejonas and metamaskbot authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d1cb468 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain 

    # Conflicts:
#	app/scripts/controllers/permissions/background-api.js
#	app/scripts/controllers/permissions/background-api.test.js
#	app/scripts/controllers/permissions/selectors.js
#	app/scripts/controllers/permissions/selectors.test.js
#	app/scripts/controllers/permissions/specifications.js
#	app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.js
#	app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.test.js
#	app/scripts/lib/rpc-method-middleware/handlers/ethereum-chain-utils.js
#	app/scripts/metamask-controller.js
#	ui/components/app/permission-page-container/permission-page-container.component.js
#	ui/selectors/permissions.js
    @jiexi
    jiexi committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    f67f115 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f6412c5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    33ff65c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    da73c69 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. bump queued-request-controller version

    @adonesky1
    adonesky1 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ef39570 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    4c1a75b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    baffa1c View commit details
    Browse the repository at this point in the history

  4. Ignore sessionId. Remove hardcoded sessionId (#27510) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27510?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d165506 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    15f622a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b6ca49a View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Do not assert unsupported required scopes (#27520) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Providing unsupportable scopes in the requiredScopes param no longer
causes the CAIP-25 request to fail immediately

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27520?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    68db523 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Jl/caip multichain/fix connection flow for permitted chains (#27471) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Connects the new AmonHenV2 Connection Flow to CAIP Multichain:
* Preserves and syncs eth accounts across eip155 scopes when permitted
chains are changed
* Grants full methods and notifications to scopeObject when a new chain
is permitted
* `ConnectPage` Approval now uses the caveat values from eth_accounts
and endowment:permitted-chains as the default selected account and
chains
* `wallet_createSession` passes a list of supported eth accounts and eth
chainIds based on the supported scopes to be used as the
preselected/default values in the ConnectPage Approval
* `wallet_createSession` removes supported eip155 scopes that were not
approved and adds ones that were not in the original request but were
approved

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27471?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

Replace the account addresses below with your own addresses to test the
preselected accounts. This request should preselect mainnet and sepolia
(which is different from the default which preselects all non testnet
networks)

```
const EXTENSION_ID = 'nonfpcflonapegmnfeafnddgdniflbnk';
const extensionPort = chrome.runtime.connect(EXTENSION_ID)
extensionPort.onMessage.addListener((msg) => console.log('extensionPort on message', msg))
extensionPort.postMessage({
    type: 'caip-x',
    data: {
        "jsonrpc": "2.0",
        method: 'wallet_createSession',
        params: {
            requiredScopes: {
                'eip155': {
                    references: ['1', '11155111'],
                    methods: [
                        'eth_sendTransaction',
                        'eth_getBalance',
                        'eth_subscribe'
                    ],
                    notifications: ['eth_subscription'],
                    accounts: ['eip155:1:0x5bA08AF1bc30f17272178bDcACA1C74e94955cF4', 'eip155:1:0xdeadbeef', 'eip155:1:0x398fC6Ec25889e7373310dC4c3491b18575d5d6B']
                }
            },
            optionalScopes: {
            },
            sessionProperties: {
                'caip154-mandatory': 'true',
            },
        },
    }
})
```

replace this with your own address to test preselected accounts.
```
 "method": "wallet_requestPermissions",
 "params": [
  {
    eth_accounts: {
        caveats: [
            {
              type: 'restrictReturnedAccounts',
                value: ['0x5bA08AF1bc30f17272178bDcACA1C74e94955cF4']
            }
            ]
    }
  }
],
});
```

This one works for preselecting chains 
```
 "method": "wallet_requestPermissions",
 "params": [
  {
    'endowment:permitted-chains': {
        caveats: [
            {
              type: 'restrictNetworkSwitching',
                value: ['0x1']
            }
            ]
    }
  }
],
});
```

You can also combine the params of these two wallet_requestPermissions
examples


One for eth_requestAccounts
```
await window.ethereum.request({
 "method": "eth_requestAccounts",
 "params": [],
});
```

And of course you can connect via the wallet UI directly.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    4126dd3 View commit details
    Browse the repository at this point in the history

  2. Handle getCaveat missing permission throws properly (#27549) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27549?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    1101102 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. CAIP Multichain: deep clone flattened scopeObjects (#27404) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Fixes bug in `wallet_createSessions` where the `accounts` permission of
ScopeObjects formed from being flattened via `scopes` array had
incorrect CAIP-10 account references in `accounts` due to the flattened
ScopeObjects all sharing the same ScopeObject reference

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27404?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a92853a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain 

    # Conflicts:
#	app/scripts/metamask-controller.js
#	app/scripts/migrations/128.test.ts
#	app/scripts/migrations/128.ts
#	app/scripts/migrations/index.js
    @jiexi
    jiexi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9ffa4b5 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. fix: bump api-specs on caip-multichain feature branch (#27585) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27585?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <[email protected]>
Co-authored-by: jiexi <[email protected]>
    @shanejonas @metamaskbot @jiexi
    3 people authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a392615 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a213b7e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    91eef62 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    bd91fb0 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Get session revoke session should not throw (#27677) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

* Update `wallet_getSession` to return empty object for sessionScopes
when no permission rather than throwing
* Update `wallet_revokeSession` to return true when no permission rather
than throwing

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27677?quickstart=1)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#3455

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8bcc777 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c6242ee View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    2852118 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge branch 'develop' into caip-multichain 

    # Conflicts:
#	app/scripts/migrations/130.test.ts
#	app/scripts/migrations/130.ts
    @jiexi
    jiexi committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    db8c573 View commit details
    Browse the repository at this point in the history

  2. fix: fix api spec multichain bump issues (#27669) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Remove unused error codes and skip wallet_getSession and revokeSession
for now. bump schema-utils-js with a couple bug fixes. Fixed parsing
ordering.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27669?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @shanejonas
    shanejonas authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2456465 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    48d19e2 View commit details
    Browse the repository at this point in the history

  4. fix: get wallet_getSession/revokeSession passing (#27741) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
uncomment `revokeSession` and `getSession` and get them passing
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27741?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Jiexi Luan <[email protected]>
    @shanejonas @jiexi
    shanejonas and jiexi authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a19cf08 View commit details
    Browse the repository at this point in the history

  5. Multichain: Lint (#27745) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27745?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6c3bc39 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Merge branch 'develop' into caip-multichain 

    # Conflicts:
#	app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.js
#	app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.test.js
#	app/scripts/lib/rpc-method-middleware/handlers/ethereum-chain-utils.js
#	app/scripts/lib/rpc-method-middleware/handlers/switch-ethereum-chain.js
#	app/scripts/lib/rpc-method-middleware/handlers/switch-ethereum-chain.test.js
#	app/scripts/metamask-controller.js
#	package.json
#	test/e2e/api-specs/ConfirmationRejectionRule.ts
#	yarn.lock
    @jiexi
    jiexi committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    42a1c8b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c3b7e52 View commit details
    Browse the repository at this point in the history

  3. Move sign methods back into eip155:x (#27771) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27771?quickstart=1)

## **Related issues**

See: MetaMask/MetaMask-planning#3483

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7221bb6 View commit details
    Browse the repository at this point in the history

  4. Jl/caip multichain/fix wallet eip155 eth account assignment (#27769) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Sets and reads eth accounts from/to `wallet:eip155` scope 

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27769?quickstart=1)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#3485

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    947dcd7 View commit details
    Browse the repository at this point in the history

  5. Multichain: Fix Subscriptions (#27682) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

On CAIP connection via externally_connectable:
* subscription and middleware for permitted chains are now instantiated
on connection open
* i.e. if you restart your wallet, you should be able to make
eth_subscribe calls for previously permitted dapps without having to
call wallet_createSession first
* subscription and middleware and are cleaned up on connection clos
* i.e. you should not get any eth_subscriptions after refreshing the
page and reconnecting
* fix CAIP stream pipeline close handler not firing
  * whoops...
* subscription and middleware are now also key'ed by tabId
  * i.e. subscriptions are isolated to the tabs they are started in

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27682?quickstart=1)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#3451

## **Manual testing steps**

```
const EXTENSION_ID = 'nonfpcflonapegmnfeafnddgdniflbnk';
const extensionPort = chrome.runtime.connect(EXTENSION_ID)
extensionPort.onMessage.addListener((msg) => {
    // format wallet_notify events nicely so that we can read them more easily later
    if (msg.data.method === 'wallet_notify') {
        console.log('wallet_notify:', {
            scope: msg.data.params.scope,
            method: msg.data.params.notification.method,
            subscription: msg.data.params.notification.params.subscription,
            number: msg.data.params.notification.params.result.number
        })
        return;
    }
    console.log(msg.data)
})

extensionPort.postMessage({
    type: 'caip-x',
    data: {
        "jsonrpc": "2.0",
        method: 'wallet_createSession',
        params: {
            requiredScopes: {
            },
            optionalScopes: {
                'eip155:1': {
                    methods: [
                        'eth_sendTransaction', 
                        'eth_subscribe'
                    ],
                    notifications: ['eth_subscription'],
                    accounts: []
                },
                'eip155:11155111': {
                    methods: [
                        'eth_sendTransaction', 
                        'eth_subscribe'
                    ],
                    notifications: ['eth_subscription'],
                    accounts: ['eip155:11155111:0x5bA08AF1bc30f17272178bDcACA1C74e94955cF4', 'eip155:11155111:0xEe166a3eec4796DeC6A1D314e7485a52bBe68e4d']
                },
                'eip155:59141': {
                    methods: [
                        'eth_sendTransaction',
                    ],
                    notifications: [],
                    accounts: []
                },
            },
        },
    }
})


extensionPort.postMessage({
    type: 'caip-x',
    data: {
        "jsonrpc": "2.0",
        method: 'wallet_invokeMethod',
        params: {
            scope: 'eip155:11155111',
            request: {
                "method": "eth_subscribe",
                 "params": [
                     "newHeads"
                ],
            }
        }
    }
})
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Shane Jonas <[email protected]>
    @jiexi @shanejonas
    jiexi and shanejonas authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0f9ba64 View commit details
    Browse the repository at this point in the history

  6. Assign eth accounts to wallets (#27777) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27777?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    14de6d2 View commit details
    Browse the repository at this point in the history

  7. initial pass

    @jiexi
    jiexi committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    50ec84a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2e06555 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f4e0bb2 View commit details
    Browse the repository at this point in the history

  3. Import attempt

    @jiexi
    jiexi committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    200a1ba View commit details
    Browse the repository at this point in the history

  4. Merge branch 'caip-multichain' into jl/caip-multichain-migrate-core

    @jiexi
    jiexi committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4f8014e View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. use barrel exported package

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8f5c024 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    146f093 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'caip-multichain' into jl/caip-multichain-migrate-core

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    33a559f View commit details
    Browse the repository at this point in the history

  4. Update LavaMoat policies

    @metamaskbot
    metamaskbot committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a4b2600 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    26dc532 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'caip-multichain' into jl/caip-multichain-migrate-core

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7ca1867 View commit details
    Browse the repository at this point in the history

  7. working preview

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e4e5793 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    28ba445 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'caip-multichain' into jl/caip-multichain-migrate-core

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    cd52a18 View commit details
    Browse the repository at this point in the history

  10. Multichain: Fix snaps connection (#27803) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

* Exclude permittedChains in eth_requestAccounts and
wallet_requestPermissions if origin is snapId
* Allow all subjectTypes to create endowment:caip25 permissions (this is
the same as eth_accounts now, i.e. not limited to certain subject types)
* Set eth accounts on upserted empty optional `wallet` and
`wallet:eip155` scopes

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27803?quickstart=1)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#3492

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    cd1861d View commit details
    Browse the repository at this point in the history

  11. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f66a26b View commit details
    Browse the repository at this point in the history

  12. upsert empty wallet:eip155 on add (#27845) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27845?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    10fb361 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'caip-multichain' into jl/caip-multichain-migrate-core

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ccb56c5 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    6adb2e4 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'caip-multichain' into jl/caip-multichain-migrate-core

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    bf0f1f8 View commit details
    Browse the repository at this point in the history

  16. move processScopedProperties validateScopedPropertyEip3085 into creat… 

    …eSession helper
    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    521b278 View commit details
    Browse the repository at this point in the history

  17. lint

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    884c830 View commit details
    Browse the repository at this point in the history

  18. Fix caipPermissionAdapterMiddleware import casing

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    70ce992 View commit details
    Browse the repository at this point in the history

  19. Merge branch 'develop' into caip-multichain

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    df11376 View commit details
    Browse the repository at this point in the history

  20. Merge branch 'caip-multichain' into jl/caip-multichain-migrate-core

    @jiexi
    jiexi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    aa5ed57 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    aa03836 View commit details
    Browse the repository at this point in the history

  2. Update app/scripts/lib/rpc-method-middleware/handlers/wallet-createSe… 

    …ssion/handler.js
    @jiexi
    jiexi authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ed4c253 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core

# Conflicts:
#	lavamoat/browserify/beta/policy.json
#	lavamoat/browserify/flask/policy.json
#	lavamoat/browserify/main/policy.json
#	lavamoat/browserify/mmi/policy.json
    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4e1df34 View commit details
    Browse the repository at this point in the history

  2. revert back to 597e8377

    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1be3e41 View commit details
    Browse the repository at this point in the history

  3. Fix createSession helper import

    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    093e5a4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e0623f5 View commit details
    Browse the repository at this point in the history

  5. Use most recent preview build

    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    245c47e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    73dd95a View commit details
    Browse the repository at this point in the history

  7. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ea0aba4 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    542f8d5 View commit details
    Browse the repository at this point in the history

  9. Remove TODO about verifying switchChain permissioning flow

    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ae5e1a5 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4db8a0d View commit details
    Browse the repository at this point in the history

  11. Revert "Remove selectors intended for multichain API" 

    This reverts commit 902bd5a.
    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    85c9fb0 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    45b5269 View commit details
    Browse the repository at this point in the history

  13. fix wallet_createSession for renamed core helpers

    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bbc90fa View commit details
    Browse the repository at this point in the history

  14. remove old js tests

    @jiexi
    jiexi committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0a6faca View commit details
    Browse the repository at this point in the history

  15. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a5907f5 View commit details
    Browse the repository at this point in the history

  16. fix: add method middleware maker and use multichain handlers (#27882) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27882?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Jiexi Luan <[email protected]>
Co-authored-by: MetaMask Bot <[email protected]>
    @shanejonas @jiexi @metamaskbot
    3 people authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1efe6e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core

# Conflicts:
#	app/scripts/lib/rpc-method-middleware/createUnsupportedMethodMiddleware.ts
#	lavamoat/browserify/beta/policy.json
#	lavamoat/browserify/flask/policy.json
#	lavamoat/browserify/main/policy.json
#	lavamoat/browserify/mmi/policy.json
    @jiexi
    jiexi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6ff8102 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    aca50f8 View commit details
    Browse the repository at this point in the history

  3. fix: remove html-report-caip27 (#27940) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27940?quickstart=1)

## **Related issues**

Fixes:
#27782 (comment)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @shanejonas
    shanejonas authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f53b91e View commit details
    Browse the repository at this point in the history

  4. bring in preview build from new core pr

    @jiexi
    jiexi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    33f3a0c View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/jl/caip-multichain-migrate-core'… 

    … into jl/caip-multichain-migrate-core
    @jiexi
    jiexi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    21701e7 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    47a08e3 View commit details
    Browse the repository at this point in the history

  7. Update LavaMoat policies

    @metamaskbot
    metamaskbot committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a0a54e2 View commit details
    Browse the repository at this point in the history

  8. update wallet_createSession handler comment about listAccounts()

    @jiexi
    jiexi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f3b68be View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/jl/caip-multichain-migrate-core'… 

    … into jl/caip-multichain-migrate-core
    @jiexi
    jiexi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a75a9fa View commit details
    Browse the repository at this point in the history

  10. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core

# Conflicts:
#	lavamoat/browserify/beta/policy.json
#	lavamoat/browserify/flask/policy.json
#	lavamoat/browserify/main/policy.json
#	lavamoat/browserify/mmi/policy.json
    @jiexi
    jiexi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    3cd8e7d View commit details
    Browse the repository at this point in the history

  11. bring in new preview build for validator listAccount()

    @jiexi
    jiexi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    db6c055 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e5b7290 View commit details
    Browse the repository at this point in the history

  13. fix yarn.lock

    @jiexi
    jiexi committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d3d76eb View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. use new preview build

    @jiexi
    jiexi committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    61becd8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core

# Conflicts:
#	app/scripts/lib/rpc-method-middleware/createUnsupportedMethodMiddleware.ts
#	lavamoat/browserify/beta/policy.json
#	lavamoat/browserify/flask/policy.json
#	lavamoat/browserify/main/policy.json
#	lavamoat/browserify/mmi/policy.json
    @jiexi
    jiexi committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7a68e3c View commit details
    Browse the repository at this point in the history

  3. lint

    @jiexi
    jiexi committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    52cad8e View commit details
    Browse the repository at this point in the history

  4. Update LavaMoat policies

    @metamaskbot
    metamaskbot committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4cc9915 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/jl/caip-multichain-migrate-core'… 

    … into jl/caip-multichain-migrate-core
    @jiexi
    jiexi committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5fae714 View commit details
    Browse the repository at this point in the history

  6. yarn dedupe

    @jiexi
    jiexi committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    83f737c View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    37f23fc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3132108 View commit details
    Browse the repository at this point in the history

  3. Bring in updated core package for types

    @jiexi
    jiexi committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    13f3907 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    bcddb19 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5b0db4d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b2c52f2 View commit details
    Browse the repository at this point in the history

  7. Jl/caip mutlichain migrate core convert create session ts (#28020) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Convert wallet_createSession to ts

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28020?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @jiexi
    jiexi authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    049493e View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    28bdb3c View commit details
    Browse the repository at this point in the history

  2. Filter wallet notifications by api type for connection

    @jiexi
    jiexi committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    0b4c431 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core

# Conflicts:
#	lavamoat/browserify/beta/policy.json
#	lavamoat/browserify/flask/policy.json
#	lavamoat/browserify/main/policy.json
#	lavamoat/browserify/mmi/policy.json
    @jiexi
    jiexi committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2d20ca8 View commit details
    Browse the repository at this point in the history

  4. Fix chainChanged still being sent for over Multichain

    @jiexi
    jiexi committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d1d754e View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4945ab1 View commit details
    Browse the repository at this point in the history

  2. Update LavaMoat policies

    @metamaskbot
    metamaskbot committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e4b4c6b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core

# Conflicts:
#	lavamoat/browserify/beta/policy.json
#	lavamoat/browserify/flask/policy.json
#	lavamoat/browserify/main/policy.json
#	lavamoat/browserify/mmi/policy.json
    @jiexi
    jiexi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    7f9135f View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Send chainChanged events as before

    @jiexi
    jiexi committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    99e35c6 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core

# Conflicts:
#	app/scripts/metamask-controller.js
#	lavamoat/browserify/beta/policy.json
#	lavamoat/browserify/flask/policy.json
#	lavamoat/browserify/main/policy.json
#	lavamoat/browserify/mmi/policy.json
#	package.json
#	yarn.lock
    @jiexi
    jiexi committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    3b4210d View commit details
    Browse the repository at this point in the history

  2. use preview build 0d167a3d (multichain + permission refactor)

    @jiexi
    jiexi committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    af9339c View commit details
    Browse the repository at this point in the history

  3. Update LavaMoat policies

    @metamaskbot
    metamaskbot committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    096d6f8 View commit details
    Browse the repository at this point in the history

  4. use preview build c58e3946 (getInternalScopesObject))

    @jiexi
    jiexi committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    2c3788a View commit details
    Browse the repository at this point in the history

  5. Fix wallet_createSession

    @jiexi
    jiexi committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    927e0c6 View commit details
    Browse the repository at this point in the history

  6. fix mergeScopes usage

    @jiexi
    jiexi committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    63695ef View commit details
    Browse the repository at this point in the history

  7. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    57630e6 View commit details
    Browse the repository at this point in the history

  8. use preview build 62975b62 (missing permission adapter middleware)

    @jiexi
    jiexi committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    a1d338a View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. yarn dedupe

    @jiexi
    jiexi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    036110b View commit details
    Browse the repository at this point in the history

  2. Fix wallet_createSession test

    @jiexi
    jiexi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    1bbc3c6 View commit details
    Browse the repository at this point in the history

  3. cleanup wallet_createSession test

    @jiexi
    jiexi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    0a24b11 View commit details
    Browse the repository at this point in the history

  4. Fix types

    @jiexi
    jiexi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    73d1db7 View commit details
    Browse the repository at this point in the history

  5. fix types

    @jiexi
    jiexi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    988891c View commit details
    Browse the repository at this point in the history

  6. lint

    @jiexi
    jiexi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    efa1804 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    426f481 View commit details
    Browse the repository at this point in the history

  8. use preview build 439ef9ba (filter out ignored 1193 methods)

    @jiexi
    jiexi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    eae656b View commit details
    Browse the repository at this point in the history

  9. use preview build 6732cd9a (loosen 1193 method enforcement)

    @jiexi
    jiexi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    06fcee2 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'caip25-permission-migration' into jl/caip-multichain-mi… 

    …grate-core
    @jiexi
    jiexi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f1dbda7 View commit details
    Browse the repository at this point in the history

  11. fix subscription not ending when removed from authorization

    @jiexi
    jiexi committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    dc848dd View commit details
    Browse the repository at this point in the history

  12. Update LavaMoat policies

    @metamaskbot
    metamaskbot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7b917ec View commit details
    Browse the repository at this point in the history