-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make Jest unit tests run faster in GitHub actions #25726
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [726823a]
Page Load Metrics (132 ± 142 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25726 +/- ##
===========================================
+ Coverage 69.77% 69.96% +0.19%
===========================================
Files 1376 1390 +14
Lines 48403 48895 +492
Branches 13348 13451 +103
===========================================
+ Hits 33773 34207 +434
- Misses 14630 14688 +58 ☔ View full report in Codecov by Sentry. |
Builds ready [0e23cd2]
Page Load Metrics (143 ± 167 ms)
Bundle size diffs
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [5dfed06]
Page Load Metrics (72 ± 8 ms)
Bundle size diffs
|
Description
Based on #25680, by migrating the jest unit tests from CircleCI to GitHub actions the time to run unit tests has increased to 15 minutes from 5 minutes. This PR makes Jest unit tests run faster in Github actions. This is achieved by some improvements to the testing infrastructure.
build/transforms
were merged into the main test configuration. This means that one less machine needs to be started (as the development tests would require their own machine to run, due to the sharding introduced in this PR), saving around approx. 2 minutes of compute time.run-unit-tests
workflow will also run on push to thedevelop
andmaster
branches.Related issues
Fixes: #25680,
Manual testing steps
Screenshots/Recordings
Not Applicable
Pre-merge author checklist
Pre-merge reviewer checklist