Skip to content

Commit

Permalink
ci: Migrate dependency linting (#29370)
Browse files Browse the repository at this point in the history
## **Description**

Migrate dependency/lockfile linting steps from CircleCI to GitHub
actions.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29370?quickstart=1)

## **Related issues**

Relates to #28572

These changes were extracted from #29256

## **Manual testing steps**

Review logs to ensure the same commands are run. Introduce errors on a
branch from here to ensure the problems are caught.
#29391

## **Screenshots/Recordings**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
Gudahtt authored Dec 20, 2024
1 parent 547b264 commit a02799d
Show file tree
Hide file tree
Showing 5 changed files with 68 additions and 43 deletions.
43 changes: 0 additions & 43 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,6 @@ workflows:
- master
requires:
- prep-deps
- test-deps-audit:
requires:
- prep-deps
- test-deps-depcheck:
requires:
- prep-deps
- test-yarn-dedupe:
requires:
- prep-deps
- validate-lavamoat-allow-scripts:
requires:
- prep-deps
Expand Down Expand Up @@ -291,7 +282,6 @@ workflows:
- prep-build-flask-mv2
- all-tests-pass:
requires:
- test-deps-depcheck
- validate-lavamoat-allow-scripts
- validate-lavamoat-policy-build
- validate-lavamoat-policy-webapp
Expand Down Expand Up @@ -964,17 +954,6 @@ jobs:
name: Rerun workflows from failed
command: yarn ci-rerun-from-failed

test-yarn-dedupe:
executor: node-browsers-small
steps:
- run: *shallow-git-clone-and-enable-vnc
- run: sudo corepack enable
- attach_workspace:
at: .
- run:
name: Detect yarn lock deduplications
command: yarn dedupe --check

test-lint:
executor: node-browsers-medium
steps:
Expand Down Expand Up @@ -1053,28 +1032,6 @@ jobs:
name: Validate release candidate changelog
command: .circleci/scripts/validate-changelog-in-rc.sh

test-deps-audit:
executor: node-browsers-small
steps:
- run: *shallow-git-clone-and-enable-vnc
- run: sudo corepack enable
- attach_workspace:
at: .
- run:
name: yarn audit
command: yarn audit

test-deps-depcheck:
executor: node-browsers-small
steps:
- run: *shallow-git-clone-and-enable-vnc
- run: sudo corepack enable
- attach_workspace:
at: .
- run:
name: depcheck
command: yarn depcheck

test-e2e-chrome-webpack:
executor: node-browsers-medium-plus
parallelism: 20
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,18 @@ jobs:
run: ${{ steps.download-actionlint.outputs.executable }} -color
shell: bash

test-deps-audit:
name: Test deps audit
uses: ./.github/workflows/test-deps-audit.yml

test-yarn-dedupe:
name: Test yarn dedupe
uses: ./.github/workflows/test-yarn-dedupe.yml

test-deps-depcheck:
name: Test deps depcheck
uses: ./.github/workflows/test-deps-depcheck.yml

run-tests:
name: Run tests
uses: ./.github/workflows/run-tests.yml
Expand All @@ -41,6 +53,8 @@ jobs:
runs-on: ubuntu-latest
needs:
- check-workflows
- test-yarn-dedupe
- test-deps-depcheck
- run-tests
- wait-for-circleci-workflow-status
outputs:
Expand Down
18 changes: 18 additions & 0 deletions .github/workflows/test-deps-audit.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Test deps audit

on:
workflow_call:

jobs:
test-deps-audit:
name: Test deps audit
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Setup environment
uses: metamask/github-tools/.github/actions/setup-environment@main

- name: Run audit
run: yarn audit
18 changes: 18 additions & 0 deletions .github/workflows/test-deps-depcheck.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Test deps depcheck

on:
workflow_call:

jobs:
test-deps-depcheck:
name: Test deps depcheck
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Setup environment
uses: metamask/github-tools/.github/actions/setup-environment@main

- name: Run depcheck
run: yarn depcheck
18 changes: 18 additions & 0 deletions .github/workflows/test-yarn-dedupe.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Test yarn dedupe

on:
workflow_call:

jobs:
test-yarn-dedupe:
name: Test yarn dedupe
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Setup environment
uses: metamask/github-tools/.github/actions/setup-environment@main

- name: Detect yarn lock deduplications
run: yarn dedupe --check

0 comments on commit a02799d

Please sign in to comment.