Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Multichain API docs #1621

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Initial Multichain API docs #1621

wants to merge 22 commits into from

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Oct 9, 2024 •
edited
Loading

Description

Initial Multichain API docs.

Issue(s) fixed

Fixes #1566

Preview

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 8:06pm

@vandan
Copy link
Contributor

vandan commented Oct 18, 2024

For MetaMask, I do not believe we need to document the scenario where wallet_createSession is used with sessionIds.

@alexandratran
Merge branch 'main' into 1566-multichain
4be0757 
# Conflicts:
#	docusaurus.config.js
#	wallet-sidebar.js
@alexandratran
Merge branch '1566-multichain' of github.com:MetaMask/metamask-docs i…
66b29ae 
…nto 1566-multichain

# Conflicts:
#	docusaurus.config.js
#	wallet-sidebar.js
@alexandratran alexandratran self-assigned this Nov 4, 2024
@alexandratran alexandratran mentioned this pull request Nov 8, 2024
Closed
2 tasks
@alexandratran alexandratran marked this pull request as ready for review November 13, 2024 23:19
@alexandratran alexandratran requested review from a team as code owners November 13, 2024 23:19
@vandan
Copy link
Contributor

vandan commented Nov 20, 2024

The CAIP standards extensively use the term "session", which insinuates a transient connection. MetaMask predominantly establishes persistent connections so we could consider using alternative terminology such as "connection". But I'm not sure if it's more confusing to diverge from the names used in the Multichain API methods.

alexandratran and others added 2 commits November 25, 2024 11:37
@alexandratran
Copy link
Contributor Author

@vandan

The CAIP standards extensively use the term "session", which insinuates a transient connection. MetaMask predominantly establishes persistent connections so we could consider using alternative terminology such as "connection". But I'm not sure if it's more confusing to diverge from the names used in the Multichain API methods.

I went ahead and updated "session" to "connection" throughout the docs. I think this is fine, but let me know if you prefer one way or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandan vandan vandan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@alexandratran alexandratran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial Multichain API docs
3 participants
@alexandratran @vandan @joaniefromtheblock