Conversation
Base automatically changed from
fix/accounts-controller-events-during-updates
to
main
April 1, 2025 09:37
ccharly
force-pushed
the
refactor/accounts-controller-type-cast-excessively-deep-type-instanciation
branch
from
f347aa0 to
9388740
Compare
ccharly
changed the title
@ts-expect-error
montelaidev
approved these changes
Apr 8, 2025
…sively-deep-type-instanciation
ccharly
deleted the
refactor/accounts-controller-type-cast-excessively-deep-type-instanciation
branch
matallui
added a commit
that referenced
this pull request
Apr 9, 2025
* main: Fix unmocked block tracker warning in NetworkController tests (#5289) ci: GH action to remind developers to add release notes in CHANGELOG.md (#5620) Release 355.0.0 (#5619) Release 354.0.0 (#5615) fix: Update origin in Snap requests (#5616) Release/353.0.0 (#5612) refactor(accounts-controller): use type-cast instead of `@ts-expect-error` (#5568) feat: support external sign transactions (#5604) feat: extend isAtomicBatchSupported result (#5600) fix: Rename `enableTxParamsGasFeeUpdates` to `isAutomaticGasFeeUpdateEnabled` and also callback (#5602) Release/352.0.0 (#5608) feat: STAKE-1005: refresh staking data when staking txs are confirmed (#5607)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Commenting out the
@ts-expect-errorwas not very reliable sometimes (it works everytime on the CI, but not everytime when compiling/running tests locally). We sometimes have to uncomment the directive to run the tests (which is a bit annoying and force you to have some "unstaged change" ingit).The type-cast does get rid of the compile-error with
WritableDraftwhile still providing the same "object signature" and has 0 impact at runtime either. So this is safe.References
N/A
Changelog
N/A
Checklist