Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[composable-controller] Enable handling of non-controller input #4943

Closed
wants to merge 8 commits into from
Closed

[composable-controller] Enable handling of non-controller input #4943

wants to merge 8 commits into from

Commits on Nov 19, 2024

  1. Widen input types for BaseController V1, V2 type guards to unknown

    @MajorLift
    MajorLift committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f0d483b View commit details
    Browse the repository at this point in the history

  2. Fix errors in jsdoc comments

    @MajorLift
    MajorLift committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    554faf8 View commit details
    Browse the repository at this point in the history

  3. Enable ComposableController to accept non-controller input

    @MajorLift
    MajorLift committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    bb2f1fd View commit details
    Browse the repository at this point in the history

  4. Align controllers and ChildControllers to both accept `NamedModul… 

    …e` types
    @MajorLift
    MajorLift committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3d44b96 View commit details
    Browse the repository at this point in the history

  5. Linter fix

    @MajorLift
    MajorLift committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e56401f View commit details
    Browse the repository at this point in the history

  6. Fix logic for excluding non-controllers from runtime state, metadata

    @MajorLift
    MajorLift committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    335c464 View commit details
    Browse the repository at this point in the history

  7. Define type guard isController

    @MajorLift
    MajorLift committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    85389bb View commit details
    Browse the repository at this point in the history

  8. Keep isController as internal feature for now 

    TODO: move to `@metamask/base-controller` once we have a type and type guard for stateless non-controllers
    @MajorLift
    MajorLift authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4fc7f5c View commit details
    Browse the repository at this point in the history