Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent parallel account syncs #4901

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

mathieuartu
Copy link
Contributor

Explanation

This PR add checks to prevent unwanted account syncs.

  • Prevent multiple parallel account sync processes
  • Prevent single operations if conditions aren't met

References

Changelog

@metamask/profile-sync-controller

  • ADDED: Account syncing safeguards to prevent multiple parallel syncs

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mathieuartu mathieuartu added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Nov 7, 2024
@mathieuartu
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.3-preview-0327163",
  "@metamask-previews/address-book-controller": "6.0.1-preview-0327163",
  "@metamask-previews/announcement-controller": "7.0.1-preview-0327163",
  "@metamask-previews/approval-controller": "7.1.1-preview-0327163",
  "@metamask-previews/assets-controllers": "42.0.0-preview-0327163",
  "@metamask-previews/base-controller": "7.0.2-preview-0327163",
  "@metamask-previews/build-utils": "3.0.1-preview-0327163",
  "@metamask-previews/chain-controller": "0.1.3-preview-0327163",
  "@metamask-previews/composable-controller": "9.0.1-preview-0327163",
  "@metamask-previews/controller-utils": "11.4.2-preview-0327163",
  "@metamask-previews/ens-controller": "15.0.0-preview-0327163",
  "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-0327163",
  "@metamask-previews/gas-fee-controller": "22.0.0-preview-0327163",
  "@metamask-previews/json-rpc-engine": "10.0.1-preview-0327163",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-0327163",
  "@metamask-previews/keyring-controller": "17.3.1-preview-0327163",
  "@metamask-previews/logging-controller": "6.0.1-preview-0327163",
  "@metamask-previews/message-manager": "11.0.1-preview-0327163",
  "@metamask-previews/multichain": "0.0.0-preview-0327163",
  "@metamask-previews/name-controller": "8.0.1-preview-0327163",
  "@metamask-previews/network-controller": "22.0.1-preview-0327163",
  "@metamask-previews/notification-controller": "7.0.0-preview-0327163",
  "@metamask-previews/notification-services-controller": "0.12.1-preview-0327163",
  "@metamask-previews/permission-controller": "11.0.3-preview-0327163",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-0327163",
  "@metamask-previews/phishing-controller": "12.3.0-preview-0327163",
  "@metamask-previews/polling-controller": "12.0.1-preview-0327163",
  "@metamask-previews/preferences-controller": "13.2.0-preview-0327163",
  "@metamask-previews/profile-sync-controller": "0.9.7-preview-0327163",
  "@metamask-previews/queued-request-controller": "7.0.1-preview-0327163",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-0327163",
  "@metamask-previews/selected-network-controller": "19.0.0-preview-0327163",
  "@metamask-previews/signature-controller": "21.0.0-preview-0327163",
  "@metamask-previews/transaction-controller": "38.3.0-preview-0327163",
  "@metamask-previews/user-operation-controller": "17.0.0-preview-0327163"
}

@mathieuartu mathieuartu marked this pull request as ready for review November 7, 2024 12:20
@mathieuartu mathieuartu requested a review from a team as a code owner November 7, 2024 12:20
@mathieuartu mathieuartu merged commit 2ccd666 into main Nov 7, 2024
121 checks passed
@mathieuartu mathieuartu deleted the feat/account_sync_improvements branch November 7, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants