Skip to content

Commit

Permalink
[TokenRatesController] - Keep addresses in checksum format (#4377)
Browse files Browse the repository at this point in the history
## Explanation

When adding market data for tokens in
#4206, it also changed the token
addresses to be lowercased instead of checksum. This PR moves it back to
the checksum format, since some places on the client expected it.

## References

<!--
Are there any issues that this pull request is tied to? Are there other
links that reviewers should consult to understand these changes better?

For example:

* Fixes #12345
* Related to #67890
-->

## Changelog

<!--
If you're making any consumer-facing changes, list those changes here as
if you were updating a changelog, using the template below as a guide.

(CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or
FIXED. For security-related issues, follow the Security Advisory
process.)

Please take care to name the exact pieces of the API you've added or
changed (e.g. types, interfaces, functions, or methods).

If there are any breaking changes, make sure to offer a solution for
consumers to follow once they upgrade to the changes.

Finally, if you're only making changes to development scripts or tests,
you may replace the template below with "None".
-->

### `@metamask/assets-controllers`

- **CHANGED**: Token rates controller uses checksum instead of lowercase
format for token addresses

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
  • Loading branch information
bergeron authored Jun 6, 2024
1 parent e922468 commit 9f3498a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/assets-controllers/src/TokenRatesController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ export class TokenRatesController extends StaticIntervalPollingControllerV1<
(obj, [tokenAddress, token]) => {
obj = {
...obj,
[tokenAddress.toLowerCase()]: { ...token },
[tokenAddress]: { ...token },
};

return obj;
Expand Down

0 comments on commit 9f3498a

Please sign in to comment.