Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove useless detect call #70

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

jd
Copy link
Member

@jd jd commented Feb 13, 2025

Depends-On: #69

jd added 2 commits February 13, 2025 17:16
Change-Id: Idaf01c18cbf9670fa705bd5bc160762aca306a11
Change-Id: I077af517d620b941cdc84db7d1d43438f93e8ff8
@jd
Copy link
Member Author

jd commented Feb 13, 2025

This pull request is part of a stack:

  1. fix: set TEST_RUN_ID to test.run.id attribute (#69)
  2. chore: remove useless detect call (#70) 👈

@jd jd mentioned this pull request Feb 13, 2025
Copy link

mergify bot commented Feb 13, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 ⛓️ Depends-On Requirements

Wonderful, this rule succeeded.

Requirement based on the presence of Depends-On in the body of the pull request

🟢 Approval

Wonderful, this rule succeeded.
  • #approved-reviews-by >= 1

🟢 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = test (3.10)
    • check-success = test (3.11)
    • check-success = test (3.12)
    • check-success = test (3.13)

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@mergify mergify bot requested a review from a team February 13, 2025 16:18
Base automatically changed from devs/jd/hex/Idaf01c18cbf9670fa705bd5bc160762aca306a11 to main February 13, 2025 16:21
@mergify mergify bot added the queued label Feb 13, 2025
@mergify mergify bot merged commit acd2be0 into main Feb 13, 2025
9 checks passed
@mergify mergify bot deleted the devs/jd/hex/I077af517d620b941cdc84db7d1d43438f93e8ff8 branch February 13, 2025 16:25
@mergify mergify bot removed the queued label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants