test: refactor plugin setup #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ApprovalThis rule is failing.
🔴 🔎 ReviewsThis rule is failing.
🟢 Continuous IntegrationWonderful, this rule succeeded.
🟢 Changelog requirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
jd
force-pushed
the
devs/jd/fix-subprocessmaybe/I75fd5057fef668c8e6dcbfe1f240f260df7e0bde
branch
from
b7356b8 to
805345a
Compare
jd
force-pushed
the
devs/jd/fix-subprocessmaybe/I75fd5057fef668c8e6dcbfe1f240f260df7e0bde
branch
from
805345a to
d602afb
Compare
I found out you can actually pass plugin instance to pytester when running it inline: this means we can grab the list of spans in a sub-pytest if we run it inline. This simplifies the overall architecture to split the tests in two mode: - either we run them in a subprocess to test the whole lifecycle (e.g. upload errors are printed) - either we run them inprocess and we can read the list of spans This will make it easier in the future to replace pytest-opentelemetry and test the spans that are emitted. Change-Id: I75fd5057fef668c8e6dcbfe1f240f260df7e0bde
jd
force-pushed
the
devs/jd/fix-subprocessmaybe/I75fd5057fef668c8e6dcbfe1f240f260df7e0bde
branch
from
d602afb to
9b4a807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out you can actually pass plugin instance to pytester when
running it inline: this means we can grab the list of spans in a
sub-pytest if we run it inline.
This simplifies the overall architecture to split the tests in two mode:
upload errors are printed)
This will make it easier in the future to replace pytest-opentelemetry
and test the spans that are emitted.