Add remove all labels option + reorganize cassettes #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new option allows to remove all labels of a pull request. Relates to #360
That should avoid potential conflicts between different test methods.
sileht
reviewed
Mar 19, 2020
| @@ -275,7 +275,7 @@ def setUp(self): | |||
| self.pr_counter = 0 | |||
| self.git_counter = 0 | |||
| self.cassette_library_dir = os.path.join( | |||
| CASSETTE_LIBRARY_DIR_BASE, self._testMethodName | |||
| CASSETTE_LIBRARY_DIR_BASE, self.__class__.__name__, self._testMethodName | |||
There was a problem hiding this comment.
Thx! I wanted to do that a long times ago and never did.
sileht
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(actions/label): add remove_all option
This new option allows to remove all labels of a pull request.
Relates to #360
refactor: move test_label in actions.test_label module
test: use class name in cassette directory
That should avoid potential conflicts between different test methods.
test: rename simulator testing class