fix: report SAML issue as fatal #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this is catched as AuthentificationFailure making Mergify retrying for ever. This change mark the SAML message as fatal. So the error message coming from Github is reported on the PullRequest. Related #1145 Fixes MERGIFY-ENGINE-1MG
jd
reviewed
Jun 2, 2020
| b"Protected branch update failed": BranchUpdateFailure, | ||
| b"Couldn't find remote ref": BranchUpdateFailure, | ||
| } | ||
| GIT_MESSAGE_TO_EXCEPTION = collections.OrderedDict( |
There was a problem hiding this comment.
SAML error also match 'The requested URL returned error, 403'. So first match first raise.
There was a problem hiding this comment.
Ok, that could have been great to have a bunch of unit test around these actually, so we're sure we don't break those.
jd
approved these changes
Jun 3, 2020
| b"Protected branch update failed": BranchUpdateFailure, | ||
| b"Couldn't find remote ref": BranchUpdateFailure, | ||
| } | ||
| GIT_MESSAGE_TO_EXCEPTION = collections.OrderedDict( |
There was a problem hiding this comment.
Ok, that could have been great to have a bunch of unit test around these actually, so we're sure we don't break those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this is catched as AuthentificationFailure making Mergify
retrying for ever. This change mark the SAML message as fatal. So
the error message coming from Github is reported on the PullRequest.
Related #1145
Fixes MERGIFY-ENGINE-1MG