Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip-idea: don't push non convential commit #496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

wip-idea: don't push non convential commit #496

wants to merge 1 commit into from

Conversation

sileht
Copy link
Member

@sileht sileht commented Oct 16, 2024 •
edited
Loading

I don't think we should hardcode convential commit. But having a
mechanism to partially push stack until a partical commit can be
usefull.

@sileht
Copy link
Member Author

sileht commented Oct 16, 2024 •
edited
Loading

This pull request is part of a stack:

  1. wip-idea: don't push non convential commit (#496) 👈
  2. fix: don't recreate merged PR (#501)

@sileht sileht mentioned this pull request Oct 16, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 16, 2024 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

Changelog requirements

  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@sileht sileht changed the base branch from devs/sileht/stop-after-commit/I8a360056e928516b4730aff5c36d2d6abcb1d76e to main October 16, 2024 13:46
@sileht sileht force-pushed the devs/sileht/stop-after-commit/Ibf570d4747f50c13b8ec0e46782831f623392ec3 branch from 4107dfc to f902aa0 Compare October 16, 2024 13:46
jd
jd previously requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@jd jd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but I think we should rather create rules such as:

  • Draft: yes is in the body
  • title starts with wip
    etc

@DouglasBlackwood
Copy link
Contributor

I agree with @jd . Other tools use headers in the body of the commit message to create draft PRs, add labels, reviewers...

@sileht
wip-idea: don't push non convential commit
4a5c79f 
I don't think we should hardcode convential commit. But having a
mechanism to partially push stack until a partical commit can be
usefull.

Change-Id: Ibf570d4747f50c13b8ec0e46782831f623392ec3
@sileht sileht force-pushed the devs/sileht/stop-after-commit/Ibf570d4747f50c13b8ec0e46782831f623392ec3 branch from f902aa0 to 4a5c79f Compare October 21, 2024 14:37
@sileht sileht mentioned this pull request Oct 21, 2024
Closed
@mergify mergify bot dismissed jd’s stale review October 21, 2024 14:38

Pull request has been modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd jd jd left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sileht @DouglasBlackwood @jd