Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: use SHA256 in alm-example #1249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bug: use SHA256 in alm-example #1249

wants to merge 1 commit into from

Conversation

rollandf
Copy link
Member

@rollandf rollandf commented Jan 9, 2025

Except for DOCA driver for now

@rollandf
bug: use SHA256 in alm-example
79fe8fb 
Except for DOCA driver for now

Signed-off-by: Fred Rolland <[email protected]>
@rollandf rollandf added the on hold This enhancement is currently on hold pending additional clarification and evaluation label Jan 9, 2025
@rollandf
Copy link
Member Author

rollandf commented Jan 9, 2025

Needs #1248

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12685833696

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 21 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 60.062%
Changes Missing Coverage Covered Lines Changed/Added Lines %
hack/release.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
controllers/macvlannetwork_controller.go 2 86.25%
api/v1alpha1/zz_generated.deepcopy.go 4 40.38%
controllers/hostdevicenetwork_controller.go 15 72.73%
Totals Coverage Status
Change from base Build 12685638732: -0.2%
Covered Lines: 3313
Relevant Lines: 5516
💛 - Coveralls

@rollandf rollandf removed the on hold This enhancement is currently on hold pending additional clarification and evaluation label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rollandf @coveralls