Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCP RMA: Fix put-based plugin #167

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

UCP RMA: Fix put-based plugin #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0a245b7
UCP RMA: Fix put-based plugin
tvegas1 Oct 3, 2024
95c140e
UCP RMA: Fix put-based plugin
tvegas1 Oct 4, 2024
0671c1d
UCP RMA: Check for null pointer before copying sizes
tvegas1 Oct 10, 2024
3cd4a68
UCP RMA: Address review comments
tvegas1 Nov 18, 2024
5bddc71
UCP RMA: Address review comments
tvegas1 Nov 18, 2024
a6b9270
UCP RMA: Address review comments
tvegas1 Nov 18, 2024
3cf2f96
UCP RMA: Address review comments
tvegas1 Nov 18, 2024
b0222cb
UCP RMA: Address review comments
tvegas1 Nov 21, 2024
bc83b44
UCP RMA: Address review comments
tvegas1 Nov 21, 2024
e582c5d
UCP RMA: Address review comments
tvegas1 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/run_nccl_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ for TEST_EXE in ${NCCL_TEST_EXE[@]}; do
#===================
# Enable ucx_rma tests once this is resolved: https://redmine.mellanox.com/issues/3037941
# for P2P_LAYER in ucx ucx_rma ib
for P2P_LAYER in ib ucx ucx_uct ucx_uct_read; do
for P2P_LAYER in ib ucx ucx_rma ucx_uct ucx_uct_read; do
MPIRUN_OPTIONS_PLUGIN_P2P_LAYER="-x NCCL_PLUGIN_P2P=${P2P_LAYER}"

#===================
Expand Down
2 changes: 1 addition & 1 deletion src/p2p_plugin.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ ncclResult_t nccl_p2p_ib_get_properties(ncclIbDev *devs, int dev, ncclNetPropert
props->maxComms = ibDev->maxQp;

if (p2p_plugin == NCCL_P2P_IB || p2p_plugin == NCCL_P2P_UCX ||
nccl_p2p_is_uct_plugin(p2p_plugin)) {
p2p_plugin == NCCL_P2P_UCX_RMA || nccl_p2p_is_uct_plugin(p2p_plugin)) {
props->maxRecvs = NCCL_NET_IB_MAX_RECVS;
} else {
props->maxRecvs = 1;
Expand Down
Loading