UCX: Create one worker per thread #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvegas1
commented
Nov 7, 2023
brminich
reviewed
Nov 7, 2023
brminich
approved these changes
Nov 10, 2023
tvegas1
force-pushed
the
dev/worker_segment
branch
from
71567a0
to
f49cf21
Compare
bureddy
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Always progress workers by the same thread to relax contention.
Why
Around 50% gain seen on small/mid-size tests. Tested up to 128 nodes.
How
Use linked-list and do not manipulate the
ucp_worker_hdirectly.