Skip to content

Commit

Permalink
Changing information about the DDR temperature sensor appearing the t…
Browse files Browse the repository at this point in the history
…he SDR repository. No reading or setting of lower critical and non-critical thresholds. Not initializing hysteresis. Not specifying nominal reading.

Test:

Before changes:

# ipmitool -I ipmb sensor get ddr_temp
Locating sensor record...
Sensor ID              : ddr_temp (0x9)
 Entity ID             : 7.2
 Sensor Type (Threshold)  : Temperature
 Sensor Reading        : 80 (+/- 0) degrees C
 Status                : ok
 Lower Non-Recoverable : na
 Lower Critical        : 0.000
 Lower Non-Critical    : 5.000
 Upper Non-Critical    : 95.000
 Upper Critical        : 105.000
 Upper Non-Recoverable : na
 Positive Hysteresis   : Unspecified
 Negative Hysteresis   : Unspecified
 Assertions Enabled    : lnc- lcr- unc+ ucr+
 Deassertions Enabled  : lnc- lcr- unc+ ucr+

After changes:

# ipmitool -I ipmb sensor get ddr_temp
Locating sensor record...
Sensor ID              : ddr_temp (0x9)
 Entity ID             : 7.2
 Sensor Type (Threshold)  : Temperature
 Sensor Reading        : 80 (+/- 0) degrees C
 Status                : ok
 Lower Non-Recoverable : na
 Lower Critical        : na
 Lower Non-Critical    : na
 Upper Non-Critical    : 95.000
 Upper Critical        : 105.000
 Upper Non-Recoverable : na
 Positive Hysteresis   : Unspecified
 Negative Hysteresis   : Unspecified
 Assertions Enabled    : unc+ ucr+
 Deassertions Enabled  : unc+ ucr+

Fixes jira https://redmine.mellanox.com/issues/4064333

Signed-off-by: Yuval Nissan <[email protected]>
  • Loading branch information
nv-ynissan committed Oct 23, 2024
1 parent 7ec4ecc commit 3799d29
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
28 changes: 14 additions & 14 deletions lanserv/mellanox-bf/mlx-bf.sdrs
Original file line number Diff line number Diff line change
Expand Up @@ -560,32 +560,32 @@ sdr type 1
init_scanning true
init_events true
init_thresholds true
init_hysteresis true
init_hysteresis false
init_sensor_type true
default_event_gen_on true
default_sensor_scan_on true
sensor_auto_rearm true
sensor_event_msg_ctrl per_state
sensor_threshold_access settable
return_lnc true
return_lc true
return_lnc false
return_lc false
return_unc true
return_uc true
deassert_lncgl true
deassert_lncgl false
deassert_uncgh true
deassert_lcgl true
deassert_lcgl false
deassert_ucgh true
assert_lncgl true
assert_lncgl false
assert_uncgh true
assert_lcgl true
assert_lcgl false
assert_ucgh true
lnc_thrsh_settable true
lnc_thrsh_settable false
unc_thrsh_settable true
lc_thrsh_settable true
lc_thrsh_settable false
uc_thrsh_settable true
lnc_thrsh_readable true
lnc_thrsh_readable false
unc_thrsh_readable true
lc_thrsh_readable true
lc_thrsh_readable false
uc_thrsh_readable true
analog_data_format unsigned
rate_unit none
Expand All @@ -594,8 +594,8 @@ sdr type 1
base_unit degrees_C
modifier_unit_code unspecified
linearization linear
nominal_specified true
nominal_reading 80
nominal_specified false
nominal_reading 0
m 1
tolerance 0
b 0
Expand All @@ -607,7 +607,7 @@ sdr type 1
sensor_maximum 255
sensor_minimum 0
lc_fthresh 0
lnc_fthresh 5
lnc_fthresh 0
unc_fthresh 95
uc_fthresh 105
positive_hysteresis 0
Expand Down
2 changes: 1 addition & 1 deletion lanserv/mellanox-bf/sdr.30.main
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
last_add_time:i:1605050738

32:d:\20\00\51\01\39\30\00\09\07\02\7f\48\01\01\85\32\85\32\1b\1b\00\01\00\00\01\00\00\05\01\00\01\50\00\00\ff\00\00\69\5f\00\00\05\00\00\00\00\00\c8ddr_temp
32:d:\20\00\51\01\33\30\00\09\07\02\77\48\01\01\80\02\80\32\18\18\00\01\00\00\01\00\00\05\01\00\00\00\00\00\ff\00\00\69\5f\00\00\00\00\00\00\00\00\c8ddr_temp
31:d:\1f\00Q\11\190\14\80\00\00\10\00\01\03\00\cedmidecode_info
30:d:\1e\00Q\11\170\13\80\00\00\10\00\01\03\00\ccproduct_name
29:d:\1d\00Q\11\110\12\80\00\00\10\00\01\03\00\c6bf_fru
Expand Down

0 comments on commit 3799d29

Please sign in to comment.