issue: 4158083 Disable DPCP and IBV dependency #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderGrissik
force-pushed
the
remove_dpcp_dependency
branch
from
19277c7 to
0e0c4fa
Compare
This is a prerequisite for further convinient seperation of DPDP and DOCA RX data path. Signed-off-by: Alexander Grissik <[email protected]>
Enable compile time decision to run DOCA or DPCP RX data path. Signed-off-by: Alexander Grissik <[email protected]>
NVMEoTCP offload was integrated functional wise but not performance tuned. Additionaly, this offload is not planed to be supported by DOCA in the foreseen future. Prefering clean code instead of having questionable feature under ifdefs. Signed-off-by: Alexander Grissik <[email protected]>
XLIO minimum compiler requirement should be C++14 for all tools and options Signed-off-by: Alexander Grissik <[email protected]>
AlexanderGrissik
force-pushed
the
remove_dpcp_dependency
branch
from
dac8197 to
9aa4426
Compare
Enable compile time decision to run DOCA or ibv TX data path. Signed-off-by: Alexander Grissik <[email protected]>
When DPCP flags are not defined dpcp adapter is compiled out completely. Signed-off-by: Alexander Grissik <[email protected]>
Remove DPCP completely from dependency when DPCP is not desired. Signed-off-by: Alexander Grissik <[email protected]>
AlexanderGrissik
force-pushed
the
remove_dpcp_dependency
branch
from
9aa4426 to
1c5f720
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing dependency of DPCP and IBV to enable clean DOCA build.
On the other hand, enable building RX or TX path with DPCP to compare performance of separate paths.
What
Why ?
DOCA TCP Library integration
How ?
Introduce two ifdefs:
DEFINED_DPCP_PATH_RX - Disables DOCA RX path and enables DPCP RX path
DEFINED_DPCP_PATH_TX - Disables DOCA TX path and enables DPCP TX path
When configured with --with-dpcp then these two macros are defined and only DPCP path will be used for both.
When configured without --with-dpcp then only DOCA path is available for both.
To enable only TX or RX path through DPCP, use --with-dpcp and comment out the unneeded define in config.h
Change type
What kind of change does this PR introduce?
Check list