Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7855 Integrate HAPI FHIR Server into Test Case Builder for internal value set expansion #106

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

adongare
Copy link
Contributor

@adongare adongare commented Nov 7, 2024

Terminology Service PR

Jira Ticket: MAT-7855
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 70.48%. Comparing base (26bc0fd) to head (a4cadf7).
Report is 31 commits behind head on develop.

Files with missing lines Patch % Lines
...erminology/service/InternalTerminologyService.java 5.26% 18 Missing ⚠️
...logy/controller/InternalTerminologyController.java 0.00% 4 Missing ⚠️
...e/terminology/controller/VsacControllerAdvice.java 0.00% 3 Missing ⚠️
...terminology/exceptions/HapiOperationException.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #106      +/-   ##
=============================================
- Coverage      75.99%   70.48%   -5.52%     
+ Complexity       232      192      -40     
=============================================
  Files             24       22       -2     
  Lines            979     1013      +34     
  Branches          80       85       +5     
=============================================
- Hits             744      714      -30     
- Misses           196      256      +60     
- Partials          39       43       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adongare adongare marked this pull request as ready for review November 7, 2024 22:14
@adongare adongare requested a review from a team as a code owner November 7, 2024 22:14
jkotanchik-SB
jkotanchik-SB previously approved these changes Nov 25, 2024
@adongare adongare merged commit d6c5177 into develop Dec 11, 2024
7 checks passed
@adongare adongare deleted the MAT-7855 branch December 11, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants