Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-8019: Add flag to control validation of QICore STU6 Test Cases. #251

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Dec 13, 2024

MADiE PR

Jira Ticket: MAT-8019
(Optional) Related Tickets:

Summary

Add flag to control validation of QICore STU6 Test Cases.

true -> validations enabled.
false -> validations disabled.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner December 13, 2024 18:51
@jkotanchik-SB jkotanchik-SB self-assigned this Dec 13, 2024
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-8019-stu6-validation-flag branch from 6d867b6 to ea354b7 Compare December 13, 2024 18:56
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7563691) to head (5d105f3).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #251   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           20        20           
=========================================
  Hits            20        20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mcmcphillips
mcmcphillips previously approved these changes Dec 13, 2024
@mcmcphillips
Copy link
Contributor

Need to resolve merge conflicts in serviceConfig

@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-8019-stu6-validation-flag branch from 82e9ca0 to f020771 Compare December 13, 2024 20:04
@jkotanchik-SB jkotanchik-SB merged commit 6d677bb into develop Dec 13, 2024
9 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-8019-stu6-validation-flag branch December 13, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants