Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Pre-commit Hook: Reorder concurrent command, run unit tests in silent mode #490

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jkotanchik-SB
Copy link
Contributor

MADiE PR

Summary

  • Run linter first to avoid mixing its output with unit tests.
  • Run unit tests in silent mode to limit testing framework complaints, making critical errors more accessible.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner November 10, 2023 16:56
@jkotanchik-SB jkotanchik-SB self-assigned this Nov 10, 2023
…mixing output.

Run unit tests in silent mode to more easily see errors by hiding testing framework complaints.
@jkotanchik-SB jkotanchik-SB force-pushed the build/pre-commit-silent-test branch from 0ca8525 to 6816154 Compare November 10, 2023 19:06
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.36%. Comparing base (3c625f3) to head (6816154).
Report is 1178 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #490   +/-   ##
========================================
  Coverage    87.36%   87.36%           
========================================
  Files          156      156           
  Lines         4503     4503           
  Branches      1030     1030           
========================================
  Hits          3934     3934           
  Misses         310      310           
  Partials       259      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3c625f3) 4142 3853 93.02%
Head commit (6816154) 4142 (+0) 3853 (+0) 93.02% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#490) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants