Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.4 #217

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Release 1.4.4 #217

merged 4 commits into from
Jun 11, 2024

Conversation

nmorasb
Copy link
Contributor

@nmorasb nmorasb commented Jun 5, 2024

MADiE PR

IF THIS IS A RELASE, PR MUST BE NAMED Release x.y.z, where x.y.z is the new version

Jira Ticket: MAT-7166
(Optional) Related Tickets:

Summary

MAT-7166: update test case import model to include metadata for export/import

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@nmorasb nmorasb requested a review from a team June 5, 2024 12:46
@nmorasb nmorasb marked this pull request as ready for review June 11, 2024 15:45
jkotanchik-SB
jkotanchik-SB previously approved these changes Jun 11, 2024
adongare
adongare previously approved these changes Jun 11, 2024
src/TestCase.ts Outdated Show resolved Hide resolved
@nmorasb nmorasb dismissed stale reviews from adongare and jkotanchik-SB via cdb2fae June 11, 2024 16:28
@nmorasb nmorasb requested a review from adongare June 11, 2024 16:28
@nmorasb nmorasb merged commit e3f41bd into main Jun 11, 2024
7 checks passed
@nmorasb nmorasb deleted the feature/MAT-7166-madie-tc-file branch June 13, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants