Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7108 fix tool tip message for qdm measures #748

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

sb-cecilialiu
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu commented Jan 15, 2025

MADiE PR

Jira Ticket: MAT-7108
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@sb-cecilialiu sb-cecilialiu requested a review from a team as a code owner January 15, 2025 22:21
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (a307178) to head (b3b29e0).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #748      +/-   ##
===========================================
- Coverage    81.07%   81.07%   -0.01%     
===========================================
  Files          309      309              
  Lines        10945    10944       -1     
  Branches      2370     2370              
===========================================
- Hits          8874     8873       -1     
  Misses        1475     1475              
  Partials       596      596              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sb-cecilialiu sb-cecilialiu merged commit f381ead into develop Jan 16, 2025
10 checks passed
@sb-cecilialiu sb-cecilialiu deleted the MAT-7108_hookUpExportTestCase_2 branch January 16, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants