Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7676 Base64Binary component #714

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Conversation

sb-cecilialiu
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu commented Dec 27, 2024

MADiE PR

Jira Ticket: MAT-7676
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@sb-cecilialiu sb-cecilialiu requested a review from a team as a code owner December 27, 2024 14:09
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (78d7c99) to head (f66d663).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...ab/builder/element/types/Base64BinaryComponent.tsx 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #714      +/-   ##
===========================================
+ Coverage    80.99%   81.00%   +0.01%     
===========================================
  Files          301      302       +1     
  Lines        10646    10663      +17     
  Branches      2298     2304       +6     
===========================================
+ Hits          8623     8638      +15     
- Misses        1447     1448       +1     
- Partials       576      577       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adongare adongare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sb-cecilialiu sb-cecilialiu merged commit 379efa9 into develop Dec 27, 2024
12 checks passed
@sb-cecilialiu sb-cecilialiu deleted the MAT-7676_base64Binary branch December 27, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants