Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7686 Test Case Builder Component - UUID #713

Merged
merged 6 commits into from
Dec 26, 2024
Merged

MAT-7686 Test Case Builder Component - UUID #713

merged 6 commits into from
Dec 26, 2024

Conversation

adongare
Copy link
Contributor

@adongare adongare commented Dec 24, 2024

MADiE PR

Jira Ticket: MAT-7686
(Optional) Related Tickets:

Summary

  • UUID component with validation
  • Can't link right now because there is no QiCore/FHIR resource that has UUID type attribute directly available on it. uuid is most available as a choice type. we do not have designs for choicetypes. we eill have to create a new ticket to handle choice types

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@adongare adongare requested a review from a team as a code owner December 24, 2024 20:58
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.99%. Comparing base (949e171) to head (75ff4c2).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...lementsTab/builder/element/types/UuidComponent.tsx 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #713      +/-   ##
===========================================
+ Coverage    80.98%   80.99%   +0.01%     
===========================================
  Files          300      301       +1     
  Lines        10634    10646      +12     
  Branches      2294     2298       +4     
===========================================
+ Hits          8612     8623      +11     
- Misses        1446     1447       +1     
  Partials       576      576              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adongare adongare merged commit 52df2f5 into develop Dec 26, 2024
13 checks passed
@adongare adongare deleted the MAT-7686 branch December 26, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants