Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7111: Modify split button to action center button #711

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Conversation

mcmcphillips
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-7111
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (df921db) to head (780b769).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...lementsTable/dataElementActions/MadieSpeedDial.tsx 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #711      +/-   ##
===========================================
- Coverage    81.01%   80.98%   -0.03%     
===========================================
  Files          303      305       +2     
  Lines        10677    10671       -6     
  Branches      2309     2307       -2     
===========================================
- Hits          8650     8642       -8     
  Misses        1449     1449              
- Partials       578      580       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adongare
adongare previously approved these changes Dec 27, 2024
@mcmcphillips mcmcphillips merged commit 142a149 into develop Dec 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants